From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-trivial@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Juan Quintela <quintela@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Thomas Huth <thuth@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
BALATON Zoltan <balaton@eik.bme.hu>, Ani Sinha <ani@anisinha.ca>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter
Date: Wed, 22 Feb 2023 12:03:38 +0100 [thread overview]
Message-ID: <9f80bb33-40e7-fc57-1515-c3764f57da46@linaro.org> (raw)
In-Reply-To: <20230213162004.2797-4-shentey@gmail.com>
On 13/2/23 17:19, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/i386/pc_q35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 66cd718b70..dee2b38474 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -218,7 +218,7 @@ static void pc_q35_init(MachineState *machine)
> pc_memory_init(pcms, get_system_memory(), rom_memory, &ram_memory,
> pci_hole64_size);
>
> - object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host));
> + object_property_add_child(OBJECT(machine), "q35", OBJECT(q35_host));
> object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_RAM_MEM,
> OBJECT(ram_memory), NULL);
> object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_PCI_MEM,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Long term we should duplicate/extract Q35MachineState from
PCMachineState and add a Q35PCIHost field, then use
object_initialize_child; removing this object_property_add_child()
call.
next prev parent reply other threads:[~2023-02-22 11:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 16:19 [PATCH v4 0/9] PC cleanups Bernhard Beschow
2023-02-13 16:19 ` [PATCH v4 1/9] hw/pci-host/i440fx: Inline sysbus_add_io() Bernhard Beschow
2023-02-22 10:58 ` Philippe Mathieu-Daudé
2023-02-22 18:05 ` Bernhard Beschow
2023-03-06 6:57 ` Bernhard Beschow
2023-03-07 22:32 ` Philippe Mathieu-Daudé
2023-02-13 16:19 ` [PATCH v4 2/9] hw/pci-host/q35: " Bernhard Beschow
2023-02-13 16:19 ` [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter Bernhard Beschow
2023-02-22 11:03 ` Philippe Mathieu-Daudé [this message]
2023-02-22 17:52 ` Bernhard Beschow
2023-02-22 20:24 ` Michael S. Tsirkin
2023-02-13 16:19 ` [PATCH v4 4/9] hw/i386/pc_{q35, piix}: Reuse MachineClass::desc as SMB product name Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 5/9] hw/i386/pc_{q35, piix}: Minimize usage of get_system_memory() Bernhard Beschow
2023-02-22 11:05 ` Philippe Mathieu-Daudé
2023-02-13 16:20 ` [PATCH v4 6/9] hw/i386/pc: Initialize ram_memory variable directly Bernhard Beschow
2023-02-22 2:38 ` Xiaoyao Li
2023-02-22 8:21 ` Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 7/9] hw/pci-host/pam: Make init_pam() usage more readable Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 8/9] hw/i386/x86: Make TYPE_X86_MACHINE the owner of smram Bernhard Beschow
2023-02-13 16:20 ` [PATCH v4 9/9] target/i386/tcg/sysemu/tcg-cpu: Avoid own opinion about smram size Bernhard Beschow
2023-02-13 16:45 ` [PATCH v4 0/9] PC cleanups Bernhard Beschow
2023-03-05 7:45 ` Bernhard Beschow
2023-03-05 10:09 ` Michael S. Tsirkin
2023-03-07 22:34 ` Philippe Mathieu-Daudé
2023-05-10 18:26 ` Bernhard Beschow
2023-05-10 19:20 ` Michael S. Tsirkin
2023-05-10 21:19 ` Bernhard Beschow
2023-02-21 15:40 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f80bb33-40e7-fc57-1515-c3764f57da46@linaro.org \
--to=philmd@linaro.org \
--cc=ani@anisinha.ca \
--cc=balaton@eik.bme.hu \
--cc=dgilbert@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).