From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD09CC61DA4 for ; Wed, 22 Feb 2023 11:04:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUmuX-0004u7-EM; Wed, 22 Feb 2023 06:03:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUmuW-0004tz-Nq for qemu-devel@nongnu.org; Wed, 22 Feb 2023 06:03:44 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUmuU-0006VX-Tk for qemu-devel@nongnu.org; Wed, 22 Feb 2023 06:03:44 -0500 Received: by mail-wr1-x42d.google.com with SMTP id i11so1149149wrp.5 for ; Wed, 22 Feb 2023 03:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zSqbD1vCGG1cLRfDz2eQbVx1XeXdaWKM9P4oNFgGsJU=; b=SFXvAsuNrQ9RLTqVJY2efbLfqGsbCQSU9RSXm6PcdbMGjVY3egEzAYpp9LU+cRswqW fgKN2koYAAq/2zbXHqFFgNptTm+wMBFIH8E9hj9b+dkLpkFBYuOBT39Fe9VwPQ69gcec H0HBQRdw0uzSGzQfGDRlLHKmYbOfxWe3wRcNoi/u6O+esPZ6S9GE/EjxkQBkZyiS53It MvVUJxNcJkHb7dQq2SvJIgEbGOH8E4HIGENZkA/UHAsaWluVmyUp3n3R5/dF00ig0qjx kYQY3S2aNpxm5XVMyrIaaloUeKgIhbIUA2KSlK9WcodHuUx+BIxQdGppMx82NzhAv1Xz usZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zSqbD1vCGG1cLRfDz2eQbVx1XeXdaWKM9P4oNFgGsJU=; b=4X6rKQEZ3pZ3fxLwidGbyQ/meqmeK0p66xhJJpQN3v0qTDIMst7WbzRlHPzwJiipP1 DlYs+aWWZ7XR1raN9dCVD7y6vzvHY0528HwrOzUCBGt1AOcKwH8lHNaNfuK5TN7yXNBs Z1uYe5OHSo4sdt96cz52JsS/nMRNWPtZwEiO7WeJx5igJ2OeWSfxDWxL6PTUTHiJke0k EcGKKmiKrgc1L1wVwj3ZBo8Rov5FP+aDk7vxTum51aj8a0ajIM+OY3POhUsDoDlZUGNR 8d9/8umFGMPUnBqtCszyukx71khDbpE1YYa+/6aAbbY5iTkJmZElAN35XGQlcbZ9/QSf 0Rqg== X-Gm-Message-State: AO0yUKVY+NlIH9G7s66l61u9rnEm/gcDEw7ujSCwpsNTT2vhDz2hUw1h D6KzdArIZ63AvUs3LIq5a5sC+A== X-Google-Smtp-Source: AK7set/eODvoeRbxba4y666mMx434dGR1Z+R7XLfgvc4yxHKlqfLG3qU5XhQRxK9I2AkiufnxYvh5g== X-Received: by 2002:a5d:4b81:0:b0:2c5:4de1:ba23 with SMTP id b1-20020a5d4b81000000b002c54de1ba23mr6763511wrt.19.1677063821162; Wed, 22 Feb 2023 03:03:41 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id j22-20020a5d4536000000b002c5a07e940csm7083448wra.33.2023.02.22.03.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 03:03:40 -0800 (PST) Message-ID: <9f80bb33-40e7-fc57-1515-c3764f57da46@linaro.org> Date: Wed, 22 Feb 2023 12:03:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter Content-Language: en-US To: Bernhard Beschow , qemu-devel@nongnu.org Cc: Paolo Bonzini , Sunil Muthuswamy , "Michael S. Tsirkin" , Marcel Apfelbaum , "Dr . David Alan Gilbert" , qemu-trivial@nongnu.org, Richard Henderson , Juan Quintela , Eduardo Habkost , Thomas Huth , Igor Mammedov , BALATON Zoltan , Ani Sinha , Laurent Vivier References: <20230213162004.2797-1-shentey@gmail.com> <20230213162004.2797-4-shentey@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230213162004.2797-4-shentey@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.095, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 13/2/23 17:19, Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow > Reviewed-by: Thomas Huth > --- > hw/i386/pc_q35.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 66cd718b70..dee2b38474 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -218,7 +218,7 @@ static void pc_q35_init(MachineState *machine) > pc_memory_init(pcms, get_system_memory(), rom_memory, &ram_memory, > pci_hole64_size); > > - object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host)); > + object_property_add_child(OBJECT(machine), "q35", OBJECT(q35_host)); > object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_RAM_MEM, > OBJECT(ram_memory), NULL); > object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_PCI_MEM, Reviewed-by: Philippe Mathieu-Daudé Long term we should duplicate/extract Q35MachineState from PCMachineState and add a Q35PCIHost field, then use object_initialize_child; removing this object_property_add_child() call.