From: Thomas Huth <thuth@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>
Cc: qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod()
Date: Fri, 14 Dec 2018 14:23:35 +0100 [thread overview]
Message-ID: <9f8c3d48-7404-b645-06e6-f44eab13d0e1@redhat.com> (raw)
In-Reply-To: <d068a183-1162-c720-e5f0-16f168f2b607@de.ibm.com>
On 2018-12-14 14:15, Christian Borntraeger wrote:
>
>
> On 14.12.2018 14:08, Thomas Huth wrote:
>> The time2tod() function tries to deal with the 9 uppermost bits in the
>> time value, but uses the wrong mask for this: 0xff80000000000000 should
>> be used instead of 0xff10000000000000 here.
>>
>> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd
>
> Can you alsways have commit id and subject
>
> like
> Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time")
In https://wiki.qemu.org/Contribute/SubmitAPatch we currently have:
Fixes: <full-SHA-commit-id>
... and the full commit ID is sometimes very useful for downstream, so
I'd rather avoid to abbreviate that here. But I can try to remember to
put the title of the patch in another spot of the description, too.
Thomas
next prev parent reply other threads:[~2018-12-14 13:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 13:08 [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod() Thomas Huth
2018-12-14 13:12 ` David Hildenbrand
2018-12-14 13:15 ` Christian Borntraeger
2018-12-14 13:23 ` Thomas Huth [this message]
2018-12-14 13:26 ` Christian Borntraeger
2018-12-14 13:30 ` Thomas Huth
2018-12-14 14:09 ` Philippe Mathieu-Daudé
2018-12-14 13:38 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8c3d48-7404-b645-06e6-f44eab13d0e1@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).