From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXnRU-0007DN-TG for qemu-devel@nongnu.org; Fri, 14 Dec 2018 08:23:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXnRQ-0003Nr-EX for qemu-devel@nongnu.org; Fri, 14 Dec 2018 08:23:48 -0500 References: <1544792887-14575-1-git-send-email-thuth@redhat.com> From: Thomas Huth Message-ID: <9f8c3d48-7404-b645-06e6-f44eab13d0e1@redhat.com> Date: Fri, 14 Dec 2018 14:23:35 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/s390x: Fix bad mask in time2tod() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , qemu-s390x@nongnu.org, Cornelia Huck Cc: qemu-devel@nongnu.org, Halil Pasic , David Hildenbrand , qemu-stable@nongnu.org On 2018-12-14 14:15, Christian Borntraeger wrote: >=20 >=20 > On 14.12.2018 14:08, Thomas Huth wrote: >> The time2tod() function tries to deal with the 9 uppermost bits in the >> time value, but uses the wrong mask for this: 0xff80000000000000 shoul= d >> be used instead of 0xff10000000000000 here. >> >> Fixes: 14055ce53c2d901d826ffad7fb7d6bb8ab46bdfd >=20 > Can you alsways have commit id and subject >=20 > like > Fixes: 14055ce53c2d ("s390x/tcg: avoid overflows in time2tod/tod2time") In https://wiki.qemu.org/Contribute/SubmitAPatch we currently have: Fixes: ... and the full commit ID is sometimes very useful for downstream, so I'd rather avoid to abbreviate that here. But I can try to remember to put the title of the patch in another spot of the description, too. Thomas