From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-stable@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 2/2] accel/tcg: Register a force_rcu notifier
Date: Mon, 18 Oct 2021 11:18:31 +0200 [thread overview]
Message-ID: <9f8f9578-1d50-e584-b401-fc7773ac1f30@redhat.com> (raw)
In-Reply-To: <20211015161218.1231920-3-groug@kaod.org>
On 15/10/21 18:12, Greg Kurz wrote:
> +void tcg_cpus_force_rcu(Notifier *notify, void *data)
> +{
> + CPUState *cpu = container_of(notify, CPUState, force_rcu);
> +
Perhaps add a comment: /* Called with rcu_registry_lock held, using
async_run_on_cpu ensudes that there are no deadlocks. */
Paolo
> + async_run_on_cpu(cpu, do_nothing, RUN_ON_CPU_NULL);
> +}
> +
prev parent reply other threads:[~2021-10-18 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:12 [PATCH 0/2] accel/tcg: Fix monitor deadlock Greg Kurz
2021-10-15 16:12 ` [PATCH 1/2] rcu: Introduce force_rcu notifier Greg Kurz
2021-10-18 9:17 ` Paolo Bonzini
2021-10-15 16:12 ` [PATCH 2/2] accel/tcg: Register a " Greg Kurz
2021-10-18 9:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8f9578-1d50-e584-b401-fc7773ac1f30@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).