From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EC7AC6FD20 for ; Fri, 24 Mar 2023 18:04:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pflm3-0007DY-8n; Fri, 24 Mar 2023 14:04:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pflm1-0007D4-Hw for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:04:21 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfllz-0005UR-BH for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:04:21 -0400 Received: by mail-pg1-x536.google.com with SMTP id bn14so1550736pgb.11 for ; Fri, 24 Mar 2023 11:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679681057; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OdwVdiv1tzpY+IhpGDFGRx7ppJPFCmksz+lZpMbCAqc=; b=LsqpW40QA3gNgnho5a28YEHtWeE8iR8RZsiQLvfuUJj5MBz3olV2WzLr9p0O7bBf2/ CdhG1vgJrYVLTVuHbCVC8yTd6P3kBifSi52lAfCmycTATfCXpuL2EWbE06XXJN3qYUlG sZpCej+kCDPZRyjiI0HcARviM5kiSkgT0V+UI0J9OkHHTHMo+0VrS3dTyU76PbtKE8Pn qppwbgleL7tWqYZffENEie7/oYmBtZZ1LmLfc6GgVZeW2G2+xLOuOpSzHgDJr31h+q0F uYxo91GdivBoTiA3igfY/tgU7ZWD2DhJQ9p7+KCIy+byXH3FqI1y3ZnkqmRNhArYgjYa hgMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679681057; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OdwVdiv1tzpY+IhpGDFGRx7ppJPFCmksz+lZpMbCAqc=; b=c9eoHfDGxd4QNnmMT4TFaVknhzqPY3ZJtaP+feBKuwAbDivG2fwpYQfozj7Vsn/UrI SIb4N1luS8se6XVRltiyv1NwSB89AYTGp9vZiaeQnrd1aldU7Gsvsf3tHhu0A1J+E8tZ Fe2XlaqDZafv7h1mD1b3N+q1iut3Nab7RdrkKdqMuCputIQdB/z4qNbhxembQ8WXsxzN RMpW2bKruKSxIHha89kxp8dXuZegTrGJZEIgi0/LZlImyf1tQkb/mHsiyh5cnzkxVAIz VzuQGlktGVH8HPrsHEpmcSjUgFU7Yzt+33wXOG9mwizCeHiSKt0ZCkrPP4tdoExRGkmJ 0PVw== X-Gm-Message-State: AAQBX9fOcnuhPFWAXUaLuhPfl8e8eBFdRdjg7gi6eVF4i3uDrp6XPzuM 2BtdhIPY20jSEZw6elQWJO41rw== X-Google-Smtp-Source: AKy350Y7ijTVC6Sx0YivgKICFOUA3xMnXzxrTrhfxirtPFHDWW5TVvjhog3DlFwsnp/wQqwgJR054A== X-Received: by 2002:a62:487:0:b0:622:c601:c0e6 with SMTP id 129-20020a620487000000b00622c601c0e6mr3370318pfe.16.1679681057591; Fri, 24 Mar 2023 11:04:17 -0700 (PDT) Received: from ?IPV6:2602:ae:1544:6601:cb42:9f2a:fcd4:54fc? ([2602:ae:1544:6601:cb42:9f2a:fcd4:54fc]) by smtp.gmail.com with ESMTPSA id u13-20020aa7838d000000b0059085684b54sm14593704pfm.140.2023.03.24.11.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 11:04:17 -0700 (PDT) Message-ID: <9f99ff8e-43e4-71d9-42b1-0d91b396da97@linaro.org> Date: Fri, 24 Mar 2023 11:04:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/8] target/riscv: Remove redundant call to riscv_cpu_virt_enabled Content-Language: en-US To: Weiwei Li , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230324123809.107714-1-liweiwei@iscas.ac.cn> <20230324123809.107714-2-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20230324123809.107714-2-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/24/23 05:38, Weiwei Li wrote: > The assignment is done under the condition riscv_cpu_virt_enabled()=true. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > target/riscv/cpu_helper.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Richard Henderson r~