From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Remove dead code relating to SABA and UABA
Date: Fri, 19 Jun 2020 21:52:52 -0700 [thread overview]
Message-ID: <9f9d22b9-da79-9d93-106f-d951b5ddea80@linaro.org> (raw)
In-Reply-To: <20200619171547.29780-1-peter.maydell@linaro.org>
On 6/19/20 10:15 AM, Peter Maydell wrote:
> In commit cfdb2c0c95ae9205b0 ("target/arm: Vectorize SABA/UABA") we
> replaced the old handling of SABA/UABA with a vectorized implementation
> which returns early rather than falling into the loop-ever-elements
> code. We forgot to delete the part of the old looping code that
> did the accumulate step, and Coverity correctly warns (CID 1428955)
> that this code is now dead. Delete it.
>
> Fixes: cfdb2c0c95ae9205b0
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/translate-a64.c | 12 ------------
> 1 file changed, 12 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-06-20 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 17:15 [PATCH] target/arm: Remove dead code relating to SABA and UABA Peter Maydell
2020-06-19 18:10 ` no-reply
2020-06-19 18:47 ` Philippe Mathieu-Daudé
2020-06-20 4:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f9d22b9-da79-9d93-106f-d951b5ddea80@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).