qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: eric.auger@redhat.com, qemu-devel@nongnu.org
Cc: Zhenzhong Duan <zhenzhong.duan@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Joao Martins <joao.m.martins@oracle.com>
Subject: Re: [PATCH v2 03/17] vfio/common: Move dirty tracking ranges update to helper
Date: Tue, 18 Jun 2024 13:22:17 +0200	[thread overview]
Message-ID: <9fa557c2-ad9f-47f0-ab40-17332badcb15@redhat.com> (raw)
In-Reply-To: <81fa58ce-a4e6-41f1-8d9a-75ad674fe472@redhat.com>

On 6/17/24 1:39 PM, Eric Auger wrote:
> Hi Cédric,
> On 6/17/24 08:33, Cédric Le Goater wrote:
>> From: Joao Martins <joao.m.martins@oracle.com>
>>
>> Separate the changes that updates the ranges from the listener, to
> s/updates/update

fixed.

>> make it reusable in preparation to expand its use to vIOMMU support.
>>
>> [ clg: - Rebased on upstream
>>         - Introduced vfio_dirty_tracking_update_range() ]
>>
>> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> ---
>>   hw/vfio/common.c | 38 ++++++++++++++++++++++----------------
>>   1 file changed, 22 insertions(+), 16 deletions(-)
>>
>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
>> index d48cd9b9361a92d184e423ffc60aabaff40fb487..fe215918bdf66ddbe3c5db803e10ce1aa9756b90 100644
>> --- a/hw/vfio/common.c
>> +++ b/hw/vfio/common.c
>> @@ -839,20 +839,11 @@ static bool vfio_section_is_vfio_pci(MemoryRegionSection *section,
>>       return false;
>>   }
>>   
>> -static void vfio_dirty_tracking_update(MemoryListener *listener,
>> -                                       MemoryRegionSection *section)
>> +static void vfio_dirty_tracking_update_range(VFIODirtyRanges *range,
>> +                                             hwaddr iova, hwaddr end,
>> +                                             bool update_pci)
>>   {
>> -    VFIODirtyRangesListener *dirty = container_of(listener,
>> -                                                  VFIODirtyRangesListener,
>> -                                                  listener);
>> -    VFIODirtyRanges *range = &dirty->ranges;
>> -    hwaddr iova, end, *min, *max;
>> -
>> -    if (!vfio_listener_valid_section(section, "tracking_update") ||
>> -        !vfio_get_section_iova_range(dirty->bcontainer, section,
>> -                                     &iova, &end, NULL)) {
>> -        return;
>> -    }
>> +    hwaddr *min, *max;
>>   
>>       /*
>>        * The address space passed to the dirty tracker is reduced to three ranges:
>> @@ -873,8 +864,7 @@ static void vfio_dirty_tracking_update(MemoryListener *listener,
>>        * The alternative would be an IOVATree but that has a much bigger runtime
>>        * overhead and unnecessary complexity.
>>        */
>> -    if (vfio_section_is_vfio_pci(section, dirty->bcontainer) &&
>> -        iova >= UINT32_MAX) {
>> +    if (update_pci && iova >= UINT32_MAX) {
>>           min = &range->minpci64;
>>           max = &range->maxpci64;
>>       } else {
>> @@ -889,7 +879,23 @@ static void vfio_dirty_tracking_update(MemoryListener *listener,
>>       }
>>   
>>       trace_vfio_device_dirty_tracking_update(iova, end, *min, *max);
> don't you want to update the name of the trace point?

There is only one caller. Let's reconsider when there are more users of this
routine.

Thanks,

C.

  
>> -    return;
>> +}
>> +
>> +static void vfio_dirty_tracking_update(MemoryListener *listener,
>> +                                       MemoryRegionSection *section)
>> +{
>> +    VFIODirtyRangesListener *dirty =
>> +        container_of(listener, VFIODirtyRangesListener, listener);
>> +    hwaddr iova, end;
>> +
>> +    if (!vfio_listener_valid_section(section, "tracking_update") ||
>> +        !vfio_get_section_iova_range(dirty->bcontainer, section,
>> +                                     &iova, &end, NULL)) {
>> +        return;
>> +    }
>> +
>> +    vfio_dirty_tracking_update_range(&dirty->ranges, iova, end,
>> +                      vfio_section_is_vfio_pci(section, dirty->bcontainer));
>>   }
>>   
>>   static const MemoryListener vfio_dirty_tracking_listener = {
> Besides
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> 
> Eric
> 



  reply	other threads:[~2024-06-18 11:22 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  6:33 [PATCH v2 00/17] vfio: QOMify VFIOContainer Cédric Le Goater
2024-06-17  6:33 ` [PATCH v2 01/17] vfio: Make vfio_devices_dma_logging_start() return bool Cédric Le Goater
2024-06-17 11:31   ` Eric Auger
2024-06-17 12:34     ` Cédric Le Goater
2024-06-17 13:55       ` Eric Auger
2024-06-17  6:33 ` [PATCH v2 02/17] vfio: Remove unused declarations from vfio-common.h Cédric Le Goater
2024-06-17 11:32   ` Eric Auger
2024-06-17  6:33 ` [PATCH v2 03/17] vfio/common: Move dirty tracking ranges update to helper Cédric Le Goater
2024-06-17 11:39   ` Eric Auger
2024-06-18 11:22     ` Cédric Le Goater [this message]
2024-06-17  6:33 ` [PATCH v2 04/17] vfio/common: Extract vIOMMU code from vfio_sync_dirty_bitmap() Cédric Le Goater
2024-06-17 14:00   ` Eric Auger
2024-06-18 11:22     ` Cédric Le Goater
2024-06-17  6:33 ` [PATCH v2 05/17] vfio/container: Introduce vfio_address_space_insert() Cédric Le Goater
2024-06-17 14:04   ` Eric Auger
2024-06-18 11:27     ` Cédric Le Goater
2024-06-17  6:33 ` [PATCH v2 06/17] vfio/container: Simplify vfio_container_init() Cédric Le Goater
2024-06-17 14:25   ` Eric Auger
2024-06-18 11:29     ` Cédric Le Goater
2024-06-17  6:33 ` [PATCH v2 07/17] vfio/container: Modify vfio_get_iommu_type() to use a container fd Cédric Le Goater
2024-06-17 14:26   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 08/17] vfio/container: Introduce vfio_get_iommu_class_name() Cédric Le Goater
2024-06-17 14:29   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 09/17] vfio/container: Introduce vfio_create_container() Cédric Le Goater
2024-06-17 14:29   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 10/17] vfio/container: Discover IOMMU type before creating the container Cédric Le Goater
2024-06-17 14:39   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 11/17] vfio/container: Change VFIOContainerBase to use QOM Cédric Le Goater
2024-06-17 15:26   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 12/17] vfio/container: Switch to QOM Cédric Le Goater
2024-06-17 15:26   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 13/17] vfio/container: Introduce an instance_init() handler Cédric Le Goater
2024-06-17 15:27   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 14/17] vfio/container: Remove VFIOContainerBase::ops Cédric Le Goater
2024-06-17 15:27   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 15/17] vfio/container: Remove vfio_container_init() Cédric Le Goater
2024-06-17 15:28   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 16/17] vfio/container: Introduce vfio_iommu_legacy_instance_init() Cédric Le Goater
2024-06-17 15:29   ` Eric Auger
2024-06-17  6:34 ` [PATCH v2 17/17] vfio/container: Move vfio_container_destroy() to an instance_finalize() handler Cédric Le Goater
2024-06-17 10:24   ` Duan, Zhenzhong
2024-06-17 15:30   ` Eric Auger
2024-06-17 16:22 ` [PATCH v2 00/17] vfio: QOMify VFIOContainer Eric Auger
2024-06-18 11:45   ` Cédric Le Goater
2024-06-24 21:17 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fa557c2-ad9f-47f0-ab40-17332badcb15@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).