From: Paolo Bonzini <pbonzini@redhat.com>
To: linzhecheng <linzc@zju.edu.cn>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds
Date: Mon, 15 Jan 2018 10:46:41 +0100 [thread overview]
Message-ID: <9fad2f5d-a8e1-cde5-711a-ecbfcda60b59@redhat.com> (raw)
In-Reply-To: <1515934519-16158-1-git-send-email-linzc@zju.edu.cn>
On 14/01/2018 13:55, linzhecheng wrote:
> We should set ioeventfd_update_pending same as memory_region_update_pending.
>
> Signed-off-by: linzhecheng <linzc@zju.edu.cn>
Thanks. This indeed fixes a bug introduced by commit
ade9c1aac5292ff698fa550adebe794c37d86cc9.
Paolo
> ---
> memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/memory.c b/memory.c
> index 4b41fb8..0cf39d0 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1091,6 +1091,7 @@ void memory_region_transaction_commit(void)
> address_space_update_ioeventfds(as);
> }
> memory_region_update_pending = false;
> + ioeventfd_update_pending = false;
> MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
> } else if (ioeventfd_update_pending) {
> QTAILQ_FOREACH(as, &address_spaces, address_spaces_link) {
>
prev parent reply other threads:[~2018-01-15 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 12:55 [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds linzhecheng
2018-01-15 9:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fad2f5d-a8e1-cde5-711a-ecbfcda60b59@redhat.com \
--to=pbonzini@redhat.com \
--cc=linzc@zju.edu.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).