* [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds
@ 2018-01-14 12:55 linzhecheng
2018-01-15 9:46 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: linzhecheng @ 2018-01-14 12:55 UTC (permalink / raw)
To: pbonzini, qemu-devel; +Cc: linzhecheng
We should set ioeventfd_update_pending same as memory_region_update_pending.
Signed-off-by: linzhecheng <linzc@zju.edu.cn>
---
memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/memory.c b/memory.c
index 4b41fb8..0cf39d0 100644
--- a/memory.c
+++ b/memory.c
@@ -1091,6 +1091,7 @@ void memory_region_transaction_commit(void)
address_space_update_ioeventfds(as);
}
memory_region_update_pending = false;
+ ioeventfd_update_pending = false;
MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
} else if (ioeventfd_update_pending) {
QTAILQ_FOREACH(as, &address_spaces, address_spaces_link) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds
2018-01-14 12:55 [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds linzhecheng
@ 2018-01-15 9:46 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2018-01-15 9:46 UTC (permalink / raw)
To: linzhecheng, qemu-devel
On 14/01/2018 13:55, linzhecheng wrote:
> We should set ioeventfd_update_pending same as memory_region_update_pending.
>
> Signed-off-by: linzhecheng <linzc@zju.edu.cn>
Thanks. This indeed fixes a bug introduced by commit
ade9c1aac5292ff698fa550adebe794c37d86cc9.
Paolo
> ---
> memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/memory.c b/memory.c
> index 4b41fb8..0cf39d0 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1091,6 +1091,7 @@ void memory_region_transaction_commit(void)
> address_space_update_ioeventfds(as);
> }
> memory_region_update_pending = false;
> + ioeventfd_update_pending = false;
> MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
> } else if (ioeventfd_update_pending) {
> QTAILQ_FOREACH(as, &address_spaces, address_spaces_link) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-14 12:55 [Qemu-devel] [PATCH] memory: set ioeventfd_update_pending after address_space_update_ioeventfds linzhecheng
2018-01-15 9:46 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).