From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Adam Baxter <voltagex@voltagex.org>, Stefan Weil <sw@weilnetz.de>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR)
Date: Tue, 29 Jan 2019 15:09:44 -0600 [thread overview]
Message-ID: <9fadf240-07c7-b569-f300-a4fc4d9044eb@redhat.com> (raw)
In-Reply-To: <20190129113921.21599-3-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On 1/29/19 5:39 AM, Daniel P. Berrangé wrote:
> This breaks when $(prefix) is a relative directory, as it turns it
> into an absolute path.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> Makefile | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Yes, it is long-standing practice among Automake and others that
$(DESTDIR) is normally empty but should contain its own trailing slash
when defined, as it is NOT separated from the rest of the installation
lines with an explicit /.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-29 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:39 [Qemu-devel] [PATCH 0/5] misc fixes to deal with icon location changes Daniel P. Berrangé
2019-01-29 11:39 ` [Qemu-devel] [PATCH 1/5] nsis: don't install files into /tmp Daniel P. Berrangé
2019-01-29 21:07 ` Eric Blake
2019-02-01 7:28 ` Stefan Weil
2019-01-29 11:39 ` [Qemu-devel] [PATCH 2/5] make: don't insert a '/' after $(DESTDIR) Daniel P. Berrangé
2019-01-29 21:09 ` Eric Blake [this message]
2019-01-29 11:39 ` [Qemu-devel] [PATCH 3/5] nsis: ensure we always pass -W64 flag to nsis installer script Daniel P. Berrangé
2019-02-01 7:18 ` Stefan Weil
2019-01-29 11:39 ` [Qemu-devel] [PATCH 4/5] nsis: fix location of icons to be bundled in the installer Daniel P. Berrangé
2019-01-29 11:39 ` [Qemu-devel] [PATCH 5/5] configure: stop trying to link non-existant bmp file from bios dir Daniel P. Berrangé
2019-01-29 11:57 ` Peter Maydell
2019-02-01 7:52 ` [Qemu-devel] [PATCH 0/5] misc fixes to deal with icon location changes Stefan Weil
2019-02-01 9:23 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fadf240-07c7-b569-f300-a4fc4d9044eb@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=voltagex@voltagex.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).