From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
jjherne@linux.ibm.com, peter.maydell@linaro.org,
pasic@linux.vnet.ibm.com, fiuczy@linux.ibm.com,
alex.williamson@redhat.com, mjrosato@linux.ibm.com,
pmorel@linux.ibm.com, alifm@linux.ibm.com, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device
Date: Mon, 28 Jan 2019 14:27:17 -0500 [thread overview]
Message-ID: <9fb4c4c5-8223-0c11-c5ba-170ff45e879f@linux.ibm.com> (raw)
In-Reply-To: <20190114151636.630d4b31.cohuck@redhat.com>
On 1/14/19 9:16 AM, Cornelia Huck wrote:
> On Thu, 10 Jan 2019 11:22:48 -0500
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>>>>> Can you extend this patch description a little bit, including what we
>>>>> discussed here?
>>>>
>>>> Maybe a short comment that explains why qdev_simple_device_unplug_cb()
>>>> is appropriate as well (i.e. hits that closing the mdev's fd is what
>>>> triggers the cleanup of the actual resources)? I personally go log
>>>> digging only once I get desperate.
>>>
>>> I go digging if I can't find a public document on how it works ;)
>>
>> Which reminds me, I will also need to update the docs/vfio-ap.txt
>> document.
>
> So, I assume there will be a v2 with some documentation changes?
I'm sorry Connie, I got sidetracked with some other priorities and
missed this response. I will post a v2 with doc changes.
>
next prev parent reply other threads:[~2019-01-28 19:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 16:01 [Qemu-devel] [PATCH] s390x/vfio-ap: Implement hot plug/unplug of vfio-ap device Tony Krowiak
2019-01-08 16:09 ` David Hildenbrand
2019-01-08 19:52 ` Tony Krowiak
2019-01-08 22:13 ` David Hildenbrand
2019-01-09 11:30 ` Cornelia Huck
2019-01-09 16:27 ` Tony Krowiak
2019-01-09 16:37 ` David Hildenbrand
2019-01-09 17:13 ` Halil Pasic
2019-01-09 17:28 ` David Hildenbrand
2019-01-10 16:22 ` Tony Krowiak
2019-01-14 14:16 ` Cornelia Huck
2019-01-28 19:27 ` Tony Krowiak [this message]
2019-01-08 16:14 ` Tony Krowiak
2019-01-09 17:05 ` [Qemu-devel] [qemu-s390x] " Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb4c4c5-8223-0c11-c5ba-170ff45e879f@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).