From: Marcel Apfelbaum <marcel@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, aik@ozlabs.ru,
"David Gibson" <dgibson@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [RFC 3/7] pci: Change pci_bus_new*() parameter to PCIHostState
Date: Tue, 18 Apr 2017 16:36:58 +0300 [thread overview]
Message-ID: <9fb8997c-0e16-2ded-4cc1-81ba06fe3465@redhat.com> (raw)
In-Reply-To: <20170418133005.GL25239@thinpad.lan.raisama.net>
On 04/18/2017 04:30 PM, Eduardo Habkost wrote:
> On Tue, Apr 18, 2017 at 04:27:23PM +0300, Marcel Apfelbaum wrote:
> [...]
>>> @@ -431,7 +430,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char *name,
>>> {
>>> PCIBus *bus;
>>>
>>> - bus = pci_bus_new(parent, name, address_space_mem,
>>> + bus = pci_bus_new(PCI_HOST_BRIDGE(parent), name, address_space_mem,
>>
>> If you request the parent to be PCI_HOST_BRIDGE, why don't you change also the signature of
>> pci_register_bus ?
>
> I do it on patch 4/7.
>
Yes, I saw it :). at least it means I am following the patches...
Thanks,
Marcel
next prev parent reply other threads:[~2017-04-18 13:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 21:59 [Qemu-devel] [RFC 0/7] pci: Type-safety and phb->bus initialization cleanup Eduardo Habkost
2017-04-17 21:59 ` [Qemu-devel] [RFC 1/7] pci: Change pci_host_bus_register() parameter to PCIHostState Eduardo Habkost
2017-04-18 3:46 ` David Gibson
2017-04-18 13:01 ` Marcel Apfelbaum
2017-04-17 21:59 ` [Qemu-devel] [RFC 2/7] pci: Change pci_bus_init() 'parent' " Eduardo Habkost
2017-04-18 3:51 ` David Gibson
2017-04-18 11:48 ` Eduardo Habkost
2017-04-18 13:22 ` Marcel Apfelbaum
2017-04-17 21:59 ` [Qemu-devel] [RFC 3/7] pci: Change pci_bus_new*() " Eduardo Habkost
2017-04-18 3:52 ` David Gibson
2017-04-18 13:27 ` Marcel Apfelbaum
2017-04-18 13:30 ` Eduardo Habkost
2017-04-18 13:36 ` Marcel Apfelbaum [this message]
2017-04-26 16:16 ` Michael S. Tsirkin
2017-04-26 17:49 ` Eduardo Habkost
2017-04-17 21:59 ` [Qemu-devel] [RFC 4/7] pci: Change pci_register_bus() 'parent' " Eduardo Habkost
2017-04-18 3:53 ` David Gibson
2017-04-18 10:41 ` Cornelia Huck
2017-04-18 13:37 ` Marcel Apfelbaum
2017-04-26 16:17 ` Michael S. Tsirkin
2017-04-17 21:59 ` [Qemu-devel] [RFC 5/7] pci: Set phb->bus inside pci_register_bus() Eduardo Habkost
2017-04-18 3:55 ` David Gibson
2017-04-18 10:42 ` Cornelia Huck
2017-04-18 13:43 ` Marcel Apfelbaum
2017-04-18 13:53 ` Eduardo Habkost
2017-04-17 21:59 ` [Qemu-devel] [RFC 6/7] pci: Set phb->bus inside pci_bus_new() Eduardo Habkost
2017-04-18 3:56 ` David Gibson
2017-04-17 21:59 ` [Qemu-devel] [RFC 7/7] pci: Set phb->bus inside pci_bus_new_inplace() Eduardo Habkost
2017-04-18 3:56 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb8997c-0e16-2ded-4cc1-81ba06fe3465@redhat.com \
--to=marcel@redhat.com \
--cc=aik@ozlabs.ru \
--cc=dgibson@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).