From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Joel Stanley <joel@jms.id.au>,
qemu-trivial@nongnu.org, Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org
Subject: Re: [PATCH] hw/watchdog/wdt_aspeed: Remove unused 'hw/misc/aspeed_scu.h' header
Date: Fri, 27 Oct 2023 17:53:16 +0200 [thread overview]
Message-ID: <9fb8d22e-feb2-4186-8da4-b44c1bf7e358@kaod.org> (raw)
In-Reply-To: <20231027134200.29906-1-philmd@linaro.org>
On 10/27/23 15:42, Philippe Mathieu-Daudé wrote:
> Aspeed watchdog doesn't use anything from the System Control Unit.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/watchdog/wdt_aspeed.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index d267aa185c..273a49d360 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -14,7 +14,6 @@
> #include "qemu/module.h"
> #include "qemu/timer.h"
> #include "sysemu/watchdog.h"
> -#include "hw/misc/aspeed_scu.h"
> #include "hw/qdev-properties.h"
> #include "hw/sysbus.h"
> #include "hw/watchdog/wdt_aspeed.h"
prev parent reply other threads:[~2023-10-27 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 13:42 [PATCH] hw/watchdog/wdt_aspeed: Remove unused 'hw/misc/aspeed_scu.h' header Philippe Mathieu-Daudé
2023-10-27 15:53 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb8d22e-feb2-4186-8da4-b44c1bf7e358@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).