From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately
Date: Thu, 11 Apr 2024 11:41:18 +0200 [thread overview]
Message-ID: <9fbc5825-e414-498a-9f70-2481a34a4411@linaro.org> (raw)
In-Reply-To: <20240410222543.0EA534E6005@zero.eik.bme.hu>
On 11/4/24 00:25, BALATON Zoltan wrote:
> Move calculation of mask after the switch which sets the function
> number for PIRQ/PINT pins to make sure the state of these pins are
> kept track of separately and IRQ is raised if any of them is active.
>
> Fixes: 7e01bd80c1 hw/isa/vt82c686: Bring back via_isa_set_irq()
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> Preferably for 9.0 if there will be another RC.
>
> hw/isa/vt82c686.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-11 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 22:25 [PATCH] hw/isa/vt82c686: Keep track of PIRQ/PINT pins separately BALATON Zoltan
2024-04-11 9:41 ` Philippe Mathieu-Daudé [this message]
2024-04-15 14:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fbc5825-e414-498a-9f70-2481a34a4411@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=npiggin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).