qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break
@ 2020-07-13  9:04 Yi Wang
  2020-07-13  9:08 ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-07-13  9:04 UTC (permalink / raw)
  To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong

From: Liao Pingfang <liao.pingfang@zte.com.cn>

Remove the superfluous break, as there is a "return" before it.

Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 
---
 fsdev/virtfs-proxy-helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index de061a8..e68acc1 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -825,7 +825,6 @@ static int process_reply(int sock, int type,
         break;
     default:
         return -1;
-        break;
     }
     return 0;
 }
-- 
2.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break
  2020-07-13  9:04 [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break Yi Wang
@ 2020-07-13  9:08 ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13  9:08 UTC (permalink / raw)
  To: Yi Wang, qemu-devel; +Cc: xue.zhihong, wang.liang82, Liao Pingfang

On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove the superfluous break, as there is a "return" before it.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 

Hmm I never reviewed this patch, only the openrisc one:
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg04078.html

Something is wrong in your workflow, you are posting each patch as
a new thread. You might be missing the --cc-cover option, see:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch

> ---
>  fsdev/virtfs-proxy-helper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index de061a8..e68acc1 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -825,7 +825,6 @@ static int process_reply(int sock, int type,
>          break;
>      default:
>          return -1;
> -        break;
>      }
>      return 0;
>  }
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-13  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13  9:04 [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break Yi Wang
2020-07-13  9:08 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).