Re: [PATCH v3] target/ppc: Make checkstop actually stop the system

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 3/7/23 14:03, Nicholas Piggin wrote:
> checkstop state does not halt the system, interrupts continue to be
> serviced, and other CPUs run. Stop the machine with
> qemu_system_guest_panicked.
> 
> Change the logging not to print separately to stderr because a
> checkstop is a guest error (or perhaps a simulated machine error)
> rather than a QEMU error. CPU registers are dumped.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

<here ...>

> 
> Since v1:
> - Fix loop exit so it stops on the checkstop-causing instruction, rather than
>    after it.
> 
> Since v2:
> - Rebase on ppc-next.

[*]

> - Use qemu_system_guest_panicked rather than vm_stop (Richard)
> - Move away from printing to stderr (Zoltan)
> - Reduce changes to log messages.
> - Split out from larger series since it's independent (will skip attn
>    instruction for now).
> ---

... goes this line, so the version changes are stripped out
when the patch is applied (usually they are not useful in the
git history).

>   target/ppc/excp_helper.c | 26 ++++++++++++++++++--------
>   1 file changed, 18 insertions(+), 8 deletions(-)