Re: [PATCH v2 1/6] hw/adc: Remove MAX111X device

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 3/10/24 16:00, Peter Maydell wrote:
> The MAX111X ADC device was used only by the XScale-based
> Zaurus machine types. Now they have all been removed, we can
> drop this device model too.
> 
> Because this device is an SSI device, in theory it could be created
> by users on the command line for boards with a different SSI
> controller, but we don't believe users are doing this -- it would be
> impossible on the command line to connect up the GPIO inputs which
> correspond to ADC inputs, or the GPIO output which is an interrupt
> line.  The only example a web search produces for "device max1111" or
> "device max1110" is our own bug report
>    https://gitlab.com/qemu-project/qemu/-/issues/2228
> where it's used as an example of a bogus command that causes an
> assertion in an aspeed machine type that wasn't expecting anything
> other than flash devices on its SMC bus.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/adc/max111x.h |  56 ----------
>   hw/adc/max111x.c         | 236 ---------------------------------------
>   hw/adc/Kconfig           |   3 -
>   hw/adc/meson.build       |   1 -
>   4 files changed, 296 deletions(-)
>   delete mode 100644 include/hw/adc/max111x.h
>   delete mode 100644 hw/adc/max111x.c

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>