qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	mdroth@linux.vnet.ibm.com, qemu-stable@nongnu.org
Subject: Re: [PATCH] hw/core/loader: Fix possible crash in rom_copy()
Date: Thu, 26 Sep 2019 08:11:26 +0200	[thread overview]
Message-ID: <9ffdb4ee-46d0-8186-c80e-6177295bd3e2@redhat.com> (raw)
In-Reply-To: <fc1616b5-1404-166a-6cae-c729ce77b1b3@redhat.com>

On 9/26/19 7:58 AM, Thomas Huth wrote:
> On 25/09/2019 22.51, Philippe Mathieu-Daudé wrote:
> [...]
>> Let's say I have write access to a LAN TFTP server used by some PXE
>> bootloader where I can store my crafted nasty kernel, then I get this score:
>>
>> https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:A/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H/E:P/RL:O/RC:C&version=3.1
>>
>> CVSS Base Score:     9.6
>> CVSS Temporal Score: 8.6
>>
>> Which seems quite high.
> 
> I don't think you can trigger this bug this way. If you load your kernel
> via a PXE server, the ELF parsing will be done by the bootloader, won't
> it? I think you can only trigger this bug here if you load your kernel
> via the "-kernel" command line parameter of QEMU (or the generic-loader
> device), so it's not a real guest escape, as far as I can see.

Ah indeed you are correct. You have to use the -kernel option to set
kernel_filename. This reduce the scores:

CVSS Base Score: 8.4
CVSS Temporal Score: 7.6
Exploitability Subscore: 1.7

You could load a kernel stored on a NFS server, but it is unlikely a
production case :)


      reply	other threads:[~2019-09-26  6:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 13:03 [PATCH] hw/core/loader: Fix possible crash in rom_copy() Thomas Huth
2019-09-25 13:22 ` Michael S. Tsirkin
2019-09-25 13:51   ` Paolo Bonzini
2019-09-25 20:51 ` Philippe Mathieu-Daudé
2019-09-26  5:53   ` Thomas Huth
2019-09-26  5:58   ` Thomas Huth
2019-09-26  6:11     ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ffdb4ee-46d0-8186-c80e-6177295bd3e2@redhat.com \
    --to=philmd@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).