From: Alex Bligh <alex@alex.org.uk>
To: "Eric Blake" <eblake@redhat.com>, "Benoît Canet" <benoit@irqsave.net>
Cc: kwolf@redhat.com, Alex Bligh <alex@alex.org.uk>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code.
Date: Fri, 26 Jul 2013 20:42:11 +0100 [thread overview]
Message-ID: <A43A4209BF3ECAA18448C290@nimrod.local> (raw)
In-Reply-To: <51F2CAF4.40103@redhat.com>
--On 26 July 2013 13:16:04 -0600 Eric Blake <eblake@redhat.com> wrote:
>> - while (qemu_co_queue_next(&bs->throttled_reqs));
>> + while (qemu_co_enter_next(&bs->throttled_reqs)) {
>> + }
>
> On first read, I missed the s/queue/enter/ change and thought all you
> were doing was the s/;/{}/ change. Is the style change necessary to
> keep checkpatch.pl happy? If not, then keeping the old style would draw
> better attention to the bug fix.
checkpatch.pl doesn't like:
while (func());
It appears happy with:
do {} while (func());
which is marginally less ugly than:
while (func()) {
};
in my opinion, particularly when used multiple times in succession.
I think this is probably a bug in checkpatch.pl.
--
Alex Bligh
next prev parent reply other threads:[~2013-07-26 19:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 16:29 [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code Benoît Canet
2013-07-26 19:16 ` Eric Blake
2013-07-26 19:42 ` Alex Bligh [this message]
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm Benoît Canet
2013-07-26 3:40 ` Fam Zheng
2013-07-26 9:48 ` Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line Benoît Canet
2013-07-26 3:07 ` Fam Zheng
2013-07-26 19:24 ` Eric Blake
2013-07-26 20:55 ` Benoît Canet
2013-08-08 13:37 ` Benoît Canet
2013-08-09 7:09 ` Kevin Wolf
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 4/5] block: Add iops_sector_count to do the iops accounting for a given io size Benoît Canet
2013-07-23 16:29 ` [Qemu-devel] [PATCH V3 for-1.6 5/5] block: Add throttling percentage metrics Benoît Canet
2013-07-26 2:55 ` Fam Zheng
2013-07-26 9:49 ` Benoît Canet
2013-07-25 12:08 ` [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features Fam Zheng
2013-07-25 12:16 ` Benoît Canet
2013-07-26 19:07 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A43A4209BF3ECAA18448C290@nimrod.local \
--to=alex@alex.org.uk \
--cc=benoit@irqsave.net \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).