qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Sebastian Herbszt" <herbszt@gmx.de>
To: Gleb Natapov <gleb@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org
Subject: Re: [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3 statetoDSDT. Handle resume event in the BIOS.
Date: Tue, 18 Nov 2008 00:07:29 +0100	[thread overview]
Message-ID: <A534A51B2B224583BCFDE65869D1D29A@FSCPC> (raw)
In-Reply-To: <20081116180129.GE6059@redhat.com>

Gleb Natapov wrote:
> On Sun, Nov 16, 2008 at 06:54:38PM +0100, Sebastian Herbszt wrote:
>> Gleb Natapov wrote:
>>> On Sun, Nov 16, 2008 at 12:50:55PM +0200, Blue Swirl wrote:
>>>> On 11/16/08, Gleb Natapov <gleb@redhat.com> wrote:
>>>> >  +void s3_resume_panic()
>>>>
>>>> How about rather:
>>>> void s3_resume_panic(void)
>>>>
>>>> >  +int
>>>> >  +s3_resume()
>>>>
>>>> s3_resume(void)?
>>>
>>> Have you tried it? :)
>>>
>>> Hint: bcc doesn't support ANSI-C.
>>
>> It accepts some ansi-c with "-ansi". Man page says
>> "-ansi  Pass  the  C  source  through unprotoize after preprocessing and
>> before code generation. This will allow some ansi C to be compiled but
>> it is definitly NOT a true ansi-C compiler."
>>
> But BOCHS doesn't use this flag. Do you what to add it and fix all
> function prototypes? Seems like to much work for a little gain.

No, i currently don't plan to change this.

- Sebastian

  reply	other threads:[~2008-11-17 23:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16  9:33 [Qemu-devel] [PATCH v4 0/5] Support for S3 ACPI state (suspend to memory) in BIOS Gleb Natapov
2008-11-16  9:33 ` [Qemu-devel] [PATCH v4 1/5] Add S3 state to DSDT. Handle resume event in the BIOS Gleb Natapov
2008-11-16 10:50   ` Blue Swirl
2008-11-16 11:01     ` Gleb Natapov
2008-11-16 11:11       ` Blue Swirl
2008-11-16 11:15         ` Gleb Natapov
2008-11-16 17:54       ` [Bochs-developers] [Qemu-devel] [PATCH v4 1/5] Add S3 state toDSDT. " Sebastian Herbszt
2008-11-16 18:01         ` Gleb Natapov
2008-11-17 23:07           ` Sebastian Herbszt [this message]
2008-11-16  9:33 ` [Qemu-devel] [PATCH v4 2/5] Preserve memory content during SMM init Gleb Natapov
2008-11-17 23:51   ` [Qemu-devel] Re: [Bochs-developers] [PATCH v4 2/5] Preserve memory content duringSMM init Sebastian Herbszt
2008-11-18  7:46     ` Gleb Natapov
2008-11-18  8:27       ` Gleb Natapov
2008-11-23 21:15         ` [Qemu-devel] Re: [Bochs-developers] [PATCH v4 2/5] Preserve memory contentduringSMM init Sebastian Herbszt
2008-11-24  7:35           ` Gleb Natapov
2008-11-16  9:34 ` [Qemu-devel] [PATCH v4 3/5] Execute rombios32 code from rom address 0xe0000 Gleb Natapov
2008-11-16  9:34 ` [Qemu-devel] [PATCH v4 4/5] Don't use unreserved memory in BIOS Gleb Natapov
2008-11-16  9:34 ` [Qemu-devel] [PATCH v4 5/5] Don't power down vga card on entering S3 state Gleb Natapov
2008-11-16 17:35 ` [Qemu-devel] Re: [Bochs-developers] [PATCH v4 0/5] Support for S3 ACPI state(suspend to memory) in BIOS Sebastian Herbszt
2008-11-16 17:38   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A534A51B2B224583BCFDE65869D1D29A@FSCPC \
    --to=herbszt@gmx.de \
    --cc=blauwirbel@gmail.com \
    --cc=bochs-developers@lists.sourceforge.net \
    --cc=gleb@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).