From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled
Date: Fri, 18 Mar 2011 21:41:00 +0900 [thread overview]
Message-ID: <AANLkTi=+JiMidH82gqENMfC0oPDPeN5+NxGYkQLErrHB@mail.gmail.com> (raw)
In-Reply-To: <1300200805-13928-1-git-send-email-quintela@redhat.com>
2011/3/15 Juan Quintela <quintela@redhat.com>:
> commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c
>
> only contains half of the fix. It forgots the save state fix for
> UINT8 indexes.
>
> Anthony, please apply, without this migration using hpet is broken.
> (only current user).
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> savevm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 60d2f2a..67459a7 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1395,6 +1395,8 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd,
> n_elems = *(int32_t *)(opaque+field->num_offset);
> } else if (field->flags & VMS_VARRAY_UINT16) {
> n_elems = *(uint16_t *)(opaque+field->num_offset);
> + } else if (field->flags & VMS_VARRAY_UINT8) {
> + n_elems = *(uint8_t *)(opaque+field->num_offset);
> }
> if (field->flags & VMS_POINTER) {
> base_addr = *(void **)base_addr + field->start;
> --
> 1.7.4
Acked-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
next prev parent reply other threads:[~2011-03-18 12:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 14:53 [Qemu-devel] [PATCH] Fix migration uint8 arrys handled Juan Quintela
2011-03-18 12:41 ` Yoshiaki Tamura [this message]
2011-03-22 0:25 ` Stefan Berger
2011-03-22 1:46 ` Anthony Liguori
2011-03-22 9:28 ` Avi Kivity
2011-03-22 10:23 ` Stefan Berger
2011-03-22 10:40 ` Avi Kivity
2011-03-22 11:50 ` Supsend/resume regression in c995b4 WAS: " Stefan Berger
2011-03-22 11:56 ` Stefan Berger
2011-03-22 12:00 ` Jan Kiszka
2011-03-22 12:21 ` Avi Kivity
2011-03-22 12:30 ` Jan Kiszka
2011-03-22 12:35 ` Avi Kivity
2011-03-22 12:33 ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 12:39 ` Jan Kiszka
2011-03-22 13:26 ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Anthony Liguori
2011-03-22 13:55 ` [Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: " Juan Quintela
2011-03-22 13:59 ` Anthony Liguori
2011-03-23 9:10 ` Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] " Avi Kivity
2011-03-23 11:22 ` Yoshiaki Tamura
2011-03-23 12:15 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=+JiMidH82gqENMfC0oPDPeN5+NxGYkQLErrHB@mail.gmail.com' \
--to=tamura.yoshiaki@lab.ntt.co.jp \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).