From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34492 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0YzI-00004u-SF
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 08:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tamura.yoshiaki@gmail.com>) id 1Q0YzG-000541-3j
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 08:41:03 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:42800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tamura.yoshiaki@gmail.com>) id 1Q0YzF-00053s-Rb
	for qemu-devel@nongnu.org; Fri, 18 Mar 2011 08:41:02 -0400
Received: by wyb42 with SMTP id 42so3946938wyb.4
	for <qemu-devel@nongnu.org>; Fri, 18 Mar 2011 05:41:01 -0700 (PDT)
MIME-Version: 1.0
Sender: tamura.yoshiaki@gmail.com
In-Reply-To: <1300200805-13928-1-git-send-email-quintela@redhat.com>
References: <1300200805-13928-1-git-send-email-quintela@redhat.com>
Date: Fri, 18 Mar 2011 21:41:00 +0900
Message-ID: <AANLkTi=+JiMidH82gqENMfC0oPDPeN5+NxGYkQLErrHB@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled
From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

2011/3/15 Juan Quintela <quintela@redhat.com>:
> commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c
>
> only contains half of the fix. =A0It forgots the save state fix for
> UINT8 indexes.
>
> Anthony, please apply, without this migration using hpet is broken.
> (only current user).
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> =A0savevm.c | =A0 =A02 ++
> =A01 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 60d2f2a..67459a7 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1395,6 +1395,8 @@ void vmstate_save_state(QEMUFile *f, const VMStateD=
escription *vmsd,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 n_elems =3D *(int32_t *)(opaque+field->nu=
m_offset);
> =A0 =A0 =A0 =A0 =A0 =A0 } else if (field->flags & VMS_VARRAY_UINT16) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 n_elems =3D *(uint16_t *)(opaque+field->n=
um_offset);
> + =A0 =A0 =A0 =A0 =A0 =A0} else if (field->flags & VMS_VARRAY_UINT8) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0n_elems =3D *(uint8_t *)(opaque+field->n=
um_offset);
> =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 =A0 =A0 =A0 if (field->flags & VMS_POINTER) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 base_addr =3D *(void **)base_addr + field=
->start;
> --
> 1.7.4

Acked-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>