From: Peter Maydell <peter.maydell@linaro.org>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Corentin Chary <corentin.chary@gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption
Date: Wed, 2 Mar 2011 22:40:41 +0000 [thread overview]
Message-ID: <AANLkTi=7jCLkdBO-s_q-RmQ7DPEDa27F8FCCkNvduajZ@mail.gmail.com> (raw)
In-Reply-To: <4D6EBE4B.8070705@mail.berlios.de>
On 2 March 2011 22:01, Stefan Weil <weil@mail.berlios.de> wrote:
> The part missing in my patch is correct handling of another
> rounding effect:
>
> VNC_DIRTY_WORDS is exact for 32 bit long values (and the
> "old" code which used uint32_t until some weeks ago), where
> VNC_DIRTY_WORDS = 2560/16/32 = 5.
>
> For 64 bit values, VNC_DIRTY_WORDS = 2560/16/64 = 2 (rounded)!
Yes, I noticed that after I posted. Given that we have arrays
like
unsigned long dirty[VNC_MAX_HEIGHT][VNC_DIRTY_WORDS];
rounding down rather than up looks a bit suspicious...
(Can we just make VNC_MAX_WIDTH a multiple of 64, or is it
baked into the VNC protocol?)
-- PMM
next prev parent reply other threads:[~2011-03-02 22:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 3:46 [Qemu-devel] [PATCH RESEND v2 1/2] fix vnc regression Wen Congyang
2011-03-02 3:58 ` [Qemu-devel] [PATCH RESEND 2/2] vnc: Fix heap corruption Wen Congyang
2011-03-02 10:57 ` [Qemu-devel] " Corentin Chary
2011-03-02 18:36 ` Stefan Weil
2011-03-02 18:47 ` Peter Maydell
2011-03-02 22:01 ` Stefan Weil
2011-03-02 22:27 ` Stefan Weil
2011-03-03 1:37 ` Wen Congyang
2011-03-02 22:40 ` Peter Maydell [this message]
2011-03-02 10:56 ` [Qemu-devel] Re: [PATCH RESEND v2 1/2] fix vnc regression Corentin Chary
2011-03-03 2:44 ` [Qemu-devel] [PATCH 3/3] correct VNC_DIRTY_WORDS on 64 bit machine Wen Congyang
2011-03-03 6:41 ` [Qemu-devel] " Corentin Chary
2011-03-03 6:42 ` Wen Congyang
2011-03-03 6:49 ` [Qemu-devel] [PATCH v2 " Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=7jCLkdBO-s_q-RmQ7DPEDa27F8FCCkNvduajZ@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=corentin.chary@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).