From: Blue Swirl <blauwirbel@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Joerg Roedel <Joerg.Roedel@amd.com>,
QEMU-devel Developers <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
tj@kernel.org, Sebastian Herbszt <herbszt@gmx.de>,
Roland Elek <elek.roland@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 10/12] config: Add header file for device config options
Date: Tue, 23 Nov 2010 19:21:28 +0000 [thread overview]
Message-ID: <AANLkTi=PTnue6buALmw14moGo6AAAQax7OfTmLb_8ruC@mail.gmail.com> (raw)
In-Reply-To: <1290522889-27559-11-git-send-email-agraf@suse.de>
On Tue, Nov 23, 2010 at 2:34 PM, Alexander Graf <agraf@suse.de> wrote:
> So far we have C preprocessor defines for target and host config
> options, but we're lacking any information on which devices are
> available.
>
> We do need that information at times though, for example in the
> ahci patch where we need to call a legacy init function depending
> on whether we have support compiled in or not.
>
> So this patch makes all config-devices options available as header
> file. Please only include it in machine description code!
How about including config-devices.h from hw/boards.h instead? On the
downside, all targets will be recompiled when config-devices.h change,
even if they don't have any device dependencies.
next prev parent reply other threads:[~2010-11-23 19:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 14:34 [Qemu-devel] [PATCH 00/12] AHCI emulation support v4 Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 01/12] ide: split ide command interpretation off Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 02/12] ide: fix whitespace gap in ide_exec_cmd Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 03/12] ide: add support for ide bus ops Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 04/12] ide: add DMA hooks to " Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 05/12] ide: add ncq identify data for ahci sata drives Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 06/12] pci: add storage class for sata Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 07/12] pci: add ich7 pci id Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation Alexander Graf
2010-11-25 12:28 ` Paul Brook
2010-11-25 12:32 ` Alexander Graf
2010-11-25 12:45 ` Paul Brook
2010-11-25 12:47 ` Alexander Graf
2010-11-25 12:52 ` Paul Brook
2010-11-23 14:34 ` [Qemu-devel] [PATCH 09/12] ahci: add -drive support Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 10/12] config: Add header file for device config options Alexander Graf
2010-11-23 19:21 ` Blue Swirl [this message]
2010-11-23 19:37 ` Alexander Graf
2010-11-24 2:22 ` [Qemu-devel] " Juan Quintela
2010-11-24 10:54 ` Alexander Graf
2010-11-24 20:45 ` Blue Swirl
2010-11-23 14:34 ` [Qemu-devel] [PATCH 11/12] ahci: spawn controller on demand Alexander Graf
2010-11-23 14:34 ` [Qemu-devel] [PATCH 12/12] ide: move pata specific parts to pata.c Alexander Graf
2010-11-24 11:44 ` [Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4 Gerd Hoffmann
2010-11-24 11:46 ` Alexander Graf
2010-12-01 23:29 ` Alexander Graf
2010-12-02 10:43 ` Gerd Hoffmann
2010-12-02 10:48 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=PTnue6buALmw14moGo6AAAQax7OfTmLb_8ruC@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=elek.roland@gmail.com \
--cc=herbszt@gmx.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).