From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/22] migration: Check that migration is active before cancel it
Date: Wed, 23 Feb 2011 17:31:49 +0900 [thread overview]
Message-ID: <AANLkTi=SDigLiq9uKtc6Sf4Ut-js-WTTY7TEwtgxm5Ef@mail.gmail.com> (raw)
In-Reply-To: <ee720c4f6ed4af5b06a40402be78a6f6a6259217.1298421307.git.quintela@redhat.com>
2011/2/23 Juan Quintela <quintela@redhat.com>:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 397a0b9..55f58c8 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -138,7 +138,7 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject **ret_data)
> {
> MigrationState *s = current_migration;
>
> - if (s)
> + if (s && s->get_status(s) == MIG_STATE_ACTIVE)
> s->cancel(s);
>
> return 0;
Why don't you remove *s again?
Yoshi
> --
> 1.7.4
>
>
>
next prev parent reply other threads:[~2011-02-23 8:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 0:44 [Qemu-devel] [PATCH 00/22] Refactor and cleaup migration code Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 01/22] migration: Make *start_outgoing_migration return FdMigrationState Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 02/22] migration: Use FdMigrationState instead of MigrationState when possible Juan Quintela
2011-02-23 9:19 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 03/22] migration: Fold MigrationState into FdMigrationState Juan Quintela
2011-02-23 8:07 ` Yoshiaki Tamura
2011-02-23 9:13 ` [Qemu-devel] " Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 04/22] migration: Rename FdMigrationState MigrationState Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 05/22] migration: Refactor MigrationState creation Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 06/22] migration: Make all posible migration functions static Juan Quintela
2011-02-23 9:28 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 07/22] migration: move migrate_create_state to do_migrate Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 08/22] migration: Check that migration is active before cancel it Juan Quintela
2011-02-23 8:31 ` Yoshiaki Tamura [this message]
2011-02-23 9:14 ` [Qemu-devel] " Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 09/22] migration: Introduce MIG_STATE_NONE Juan Quintela
2011-02-23 9:36 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 10/22] migration: Refactor and simplify error checking in migrate_fd_put_ready Juan Quintela
2011-02-23 9:51 ` Yoshiaki Tamura
2011-02-23 10:08 ` [Qemu-devel] " Juan Quintela
2011-02-23 11:36 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 11/22] migration: Introduce migrate_fd_completed() for consistenncy Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 12/22] migration: Use migrate_fd_error() in last place that set status to ERROR Juan Quintela
2011-02-23 8:25 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 13/22] migration: Our release callback was just free Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 14/22] migration: Remove get_status() accessor Juan Quintela
2011-02-23 8:42 ` Yoshiaki Tamura
2011-02-23 9:18 ` [Qemu-devel] " Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 15/22] migration: Remove migration cancel() callback Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 16/22] migration: Move exported functions to the end of the file Juan Quintela
2011-02-23 9:07 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 17/22] migration: use global variable directly Juan Quintela
2011-02-23 8:15 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 18/22] migration: another case of global variable assigned to local one Juan Quintela
2011-02-23 8:54 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 19/22] migration: convert current_migration from pointer to struct Juan Quintela
2011-02-23 8:53 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 20/22] migration: Use bandwidth_limit directly Juan Quintela
2011-02-23 0:44 ` [Qemu-devel] [PATCH 21/22] migration: Export a function that tells if the migration has finished correctly Juan Quintela
2011-02-23 8:50 ` Yoshiaki Tamura
2011-02-23 0:44 ` [Qemu-devel] [PATCH 22/22] migration: Make state definitions local Juan Quintela
2011-02-23 8:35 ` Yoshiaki Tamura
2011-02-23 9:21 ` [Qemu-devel] " Juan Quintela
2011-02-24 4:19 ` Yoshiaki Tamura
2011-02-24 12:23 ` Juan Quintela
2011-02-24 14:46 ` Anthony Liguori
2011-02-25 1:27 ` Yoshiaki Tamura
2011-02-25 1:20 ` Yoshiaki Tamura
2011-02-23 9:03 ` [Qemu-devel] Re: [PATCH 00/22] Refactor and cleaup migration code Paolo Bonzini
2011-02-23 10:15 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=SDigLiq9uKtc6Sf4Ut-js-WTTY7TEwtgxm5Ef@mail.gmail.com' \
--to=tamura.yoshiaki@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).