From: Igor Kovalenko <igor.v.kovalenko@gmail.com>
To: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path construction
Date: Mon, 31 Jan 2011 22:01:25 +0300 [thread overview]
Message-ID: <AANLkTi=b5JU9oF=cGmFXNAnXfe-0v3jkkKiu5ciEYy2Z@mail.gmail.com> (raw)
In-Reply-To: <4D46CD96.5090809@siriusit.co.uk>
On Mon, Jan 31, 2011 at 5:56 PM, Mark Cave-Ayland
<mark.cave-ayland@siriusit.co.uk> wrote:
> On 18/01/11 21:10, Igor V. Kovalenko wrote:
>
>> From: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>>
>> - fix snprintf off by one
>> pci domain and slot number formatting snprintf calls
>> require extra space for trailing null character
>>
>> without this change devices are assigned the same path name
>> which triggers assertion in vmstate_register_with_alias_id
>>
>> - while iterating over devices from root pci device
>> use PCI_SLOT and PCI_FUNC of each device on the path
>> instead of always extracting PCI_FUNC of original device
>>
>> Signed-off-by: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>> ---
>> hw/pci.c | 28 ++++++++++++++++++++--------
>> 1 files changed, 20 insertions(+), 8 deletions(-)
>>
>
> Has anyone had a chance to look at this patch yet?
>
The issue is already fixed in the tree differently by
commits e10990c3f0c39e92ab5f74004b89a24fcc36fa14
and 2991181aaa026d8b1444bfaa9c4bcd82065ba5a3
--
Kind regards,
Igor V. Kovalenko
prev parent reply other threads:[~2011-01-31 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 21:10 [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path construction Igor V. Kovalenko
2011-01-31 14:56 ` Mark Cave-Ayland
2011-01-31 19:01 ` Igor Kovalenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=b5JU9oF=cGmFXNAnXfe-0v3jkkKiu5ciEYy2Z@mail.gmail.com' \
--to=igor.v.kovalenko@gmail.com \
--cc=mark.cave-ayland@siriusit.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).