From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33696 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pjz0D-0004MZ-W2
	for qemu-devel@nongnu.org; Mon, 31 Jan 2011 14:01:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1Pjz0C-0007J6-4I
	for qemu-devel@nongnu.org; Mon, 31 Jan 2011 14:01:29 -0500
Received: from mail-fx0-f45.google.com ([209.85.161.45]:33240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <igor.v.kovalenko@gmail.com>) id 1Pjz0B-0007IR-Qb
	for qemu-devel@nongnu.org; Mon, 31 Jan 2011 14:01:28 -0500
Received: by fxm12 with SMTP id 12so6147542fxm.4
	for <qemu-devel@nongnu.org>; Mon, 31 Jan 2011 11:01:25 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4D46CD96.5090809@siriusit.co.uk>
References: <20110118211016.9850.63478.stgit@skyserv>
	<4D46CD96.5090809@siriusit.co.uk>
Date: Mon, 31 Jan 2011 22:01:25 +0300
Message-ID: <AANLkTi=b5JU9oF=cGmFXNAnXfe-0v3jkkKiu5ciEYy2Z@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] pcibus_get_dev_path: correct pci device path
	construction
From: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
Cc: qemu-devel@nongnu.org

On Mon, Jan 31, 2011 at 5:56 PM, Mark Cave-Ayland
<mark.cave-ayland@siriusit.co.uk> wrote:
> On 18/01/11 21:10, Igor V. Kovalenko wrote:
>
>> From: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>>
>> - fix snprintf off by one
>> =A0 pci domain and slot number formatting snprintf calls
>> =A0 require extra space for trailing null character
>>
>> =A0 without this change devices are assigned the same path name
>> =A0 which triggers assertion in vmstate_register_with_alias_id
>>
>> - while iterating over devices from root pci device
>> =A0 use PCI_SLOT and PCI_FUNC of each device on the path
>> =A0 instead of always extracting PCI_FUNC of original device
>>
>> Signed-off-by: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>> ---
>> =A0hw/pci.c | =A0 28 ++++++++++++++++++++--------
>> =A01 files changed, 20 insertions(+), 8 deletions(-)
>>
>
> Has anyone had a chance to look at this patch yet?
>

The issue is already fixed in the tree differently by
commits e10990c3f0c39e92ab5f74004b89a24fcc36fa14
and 2991181aaa026d8b1444bfaa9c4bcd82065ba5a3

--=20
Kind regards,
Igor V. Kovalenko