From: Blue Swirl <blauwirbel@gmail.com>
To: riku voipio <riku.voipio@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/7] linux-user: Implement FS_IOC_FIEMAP ioctl
Date: Sun, 9 Jan 2011 19:08:48 +0000 [thread overview]
Message-ID: <AANLkTi=btr-p9nfxAy1A264xw+=4DLdhpWs54hv-0sLs@mail.gmail.com> (raw)
In-Reply-To: <4D29F4A0.1050500@iki.fi>
On Sun, Jan 9, 2011 at 5:47 PM, riku voipio <riku.voipio@iki.fi> wrote:
> On 01/09/2011 04:47 PM, Blue Swirl wrote:
>>
>> This fails if the file doesn't exist:
>> CC i386-linux-user/syscall.o
>> /src/qemu/linux-user/syscall.c:86:26: error: linux/fiemap.h: No such
>> file or directory
>
>> The fix is to introduce a feature check in configure.
>
> Perhaps we can do without configure check, since FS_IOC_FIEMAP is defined in
> fs.h if fiemap.h is available. See the attached patch.
It's a bit fragile compared to a configure check, but I confirm it works.
Acked-by: Blue Swirl <blauwirbel@gmail.com>
next prev parent reply other threads:[~2011-01-09 19:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:52 [Qemu-devel] [PATCH 0/7] linux-user fixes for pull Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 1/7] linux-user: Implement sync_file_range{, 2} syscalls Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 2/7] linux-user: Support ioctls whose parameter size is not constant Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 3/7] linux-user: Implement FS_IOC_FIEMAP ioctl Riku Voipio
2011-01-09 14:47 ` Blue Swirl
2011-01-09 17:47 ` riku voipio
2011-01-09 19:08 ` Blue Swirl [this message]
2011-01-10 4:01 ` Peter Maydell
2011-01-09 20:06 ` Martin Mohring
2011-01-07 20:52 ` [Qemu-devel] [PATCH 4/7] softfloat: Implement floatx80_is_any_nan() and float128_is_any_nan() Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 5/7] linux-user: Fix incorrect NaN detection in ARM nwfpe emulation Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 6/7] Fix commandline handling for ARM semihosted executables Riku Voipio
2011-01-07 20:52 ` [Qemu-devel] [PATCH 7/7] Remove dead code for ARM semihosting commandline handling Riku Voipio
2011-01-08 15:35 ` [Qemu-devel] [PATCH 0/7] linux-user fixes for pull Aurelien Jarno
2011-01-08 23:25 ` [Qemu-devel] [PATCH] linux-user: fix for loopmount ioctl Martin Mohring
2011-01-10 16:18 ` Martin Mohring
2011-01-10 21:13 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=btr-p9nfxAy1A264xw+=4DLdhpWs54hv-0sLs@mail.gmail.com' \
--to=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).