qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: hch@infradead.org, Jes.Sorensen@redhat.com,
	qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write
Date: Tue, 22 Feb 2011 15:16:50 +0000	[thread overview]
Message-ID: <AANLkTi=kdSyfrqejZjYpmVbtN+_KSuBZVCQ7MzWZ9+if@mail.gmail.com> (raw)
In-Reply-To: <4D63D217.9080206@redhat.com>

On Tue, Feb 22, 2011 at 3:11 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
>> Why are we even allowing requests that extend beyond the end of the
>> device?  Is the LVM volume marked growable in the QEMU block layer?
>
> Might well be a qcow2 on LVM case that Jes was debugging.

Yes it is.  It doesn't explain it though.  The code involved here is
linux-aio.c and will be qcow2's bs->file.  That ought to be a
host_device and AFAIK that is not growable.  So I wanted to figure out
why we're even getting this far.  I expected the request to get
rejected in block.c when checking the range against the host_device.

Stefan

  reply	other threads:[~2011-02-22 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22 10:17 [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write Jes.Sorensen
2011-02-22 10:18 ` Jes.Sorensen
2011-02-22 11:44   ` [Qemu-devel] " Kevin Wolf
2011-02-22 11:45     ` Jes Sorensen
2011-02-22 13:56       ` Avi Kivity
2011-02-22 15:02   ` [Qemu-devel] " Stefan Hajnoczi
2011-02-22 15:11     ` Kevin Wolf
2011-02-22 15:16       ` Stefan Hajnoczi [this message]
2011-02-22 16:59         ` [Qemu-devel] " Paolo Bonzini
2011-03-01 20:19           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=kdSyfrqejZjYpmVbtN+_KSuBZVCQ7MzWZ9+if@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=hch@infradead.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).