From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56708 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Prtyy-0005bz-2V
	for qemu-devel@nongnu.org; Tue, 22 Feb 2011 10:16:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Prtyx-0006Oy-73
	for qemu-devel@nongnu.org; Tue, 22 Feb 2011 10:16:55 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:44374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Prtyx-0006Or-4J
	for qemu-devel@nongnu.org; Tue, 22 Feb 2011 10:16:55 -0500
Received: by gyd8 with SMTP id 8so1025536gyd.4
	for <qemu-devel@nongnu.org>; Tue, 22 Feb 2011 07:16:54 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4D63D217.9080206@redhat.com>
References: <1298369880-23859-1-git-send-email-Jes.Sorensen@redhat.com>
	<1298369880-23859-2-git-send-email-Jes.Sorensen@redhat.com>
	<AANLkTimrQXxX-4eAmcJstB8g_apaaDqoCf6twhd2t=_D@mail.gmail.com>
	<4D63D217.9080206@redhat.com>
Date: Tue, 22 Feb 2011 15:16:50 +0000
Message-ID: <AANLkTi=kdSyfrqejZjYpmVbtN+_KSuBZVCQ7MzWZ9+if@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: hch@infradead.org, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Tue, Feb 22, 2011 at 3:11 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
>> Why are we even allowing requests that extend beyond the end of the
>> device? =A0Is the LVM volume marked growable in the QEMU block layer?
>
> Might well be a qcow2 on LVM case that Jes was debugging.

Yes it is.  It doesn't explain it though.  The code involved here is
linux-aio.c and will be qcow2's bs->file.  That ought to be a
host_device and AFAIK that is not growable.  So I wanted to figure out
why we're even getting this far.  I expected the request to get
rejected in block.c when checking the range against the host_device.

Stefan