From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52662 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnGfx-0005Z3-1y
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 16:01:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OnGWO-0005B6-CG
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:48:01 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:44129)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OnGWO-0005Au-8T
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:48:00 -0400
Received: by qwh5 with SMTP id 5so4678002qwh.4
	for <qemu-devel@nongnu.org>; Sun, 22 Aug 2010 12:47:59 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4C717A6C.9080805@codemonkey.ws>
References: <AANLkTikc=-mLwgK4WkhMEuhxbzVuiMn354=agB11H4W1@mail.gmail.com>
	<alpine.LNX.2.00.1008122251300.1975@linmac>
	<AANLkTin34MbLNV7N+cQVtft2q6BkgAD2nA6oBASk9oah@mail.gmail.com>
	<AANLkTimM5aaYyfTkOpN-EpTqKM6uKLMv7E9ioGxdYudS@mail.gmail.com>
	<4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws>
	<m3vd75flas.fsf@blackfin.pond.sub.org>
	<AANLkTi=M91uUvp4dVc26oijUqHDwwHm6kLmL6txSb9ty@mail.gmail.com>
	<AANLkTi=Ra=jgjxQ=zORSOrkOj8hTFDxfExJkQ9ZT-u3Y@mail.gmail.com>
	<m3eidsxpdo.fsf@blackfin.pond.sub.org>
	<AANLkTikgZtj0fdXhv_hj9ffvoJe1dFCEU6Cv8Qk2u5Gj@mail.gmail.com>
	<m3bp8wp30w.fsf@blackfin.pond.sub.org>
	<AANLkTikAg-Ged4JiBLxcb6=joKY=mSwtir9GM9z4tNJU@mail.gmail.com>
	<4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws>
	<AANLkTinnoZLa_NTX3i1R7KOQd7Zw7VN=Lbg1DDZB3Bph@mail.gmail.com>
	<4C717A6C.9080805@codemonkey.ws>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 22 Aug 2010 19:47:39 +0000
Message-ID: <AANLkTi=kpbeUYLvnijOFn8dVQjFvLHLqPOHsc7Jjd1aH@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, Miguel Di Ciurcio Filho <miguel.filho@gmail.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Sun, Aug 22, 2010 at 7:28 PM, Anthony Liguori <anthony@codemonkey.ws> wr=
ote:
> On 08/22/2010 01:56 PM, Blue Swirl wrote:
>>>
>>> Why is this even still being discussed? =C2=A0What problem are people a=
ctually
>>> trying to solve?
>>>
>>> Can someone point to a bug in QEMU that's been caused because of
>>> CODING_STYLE or the fact that some patches don't adhere to it?
>>>
>>
>> 7b1df88f284f462ecb236931ad863a815f243195
>>
>
> That's a hell of a bug :-)

Yeah. IIRC I almost dismissed the warning from clang as false positive
because I just couldn't see any bug.

>>> I don't see a problem with the way things are today.
>>>
>>
>> There is the problem that some patch submitters are reminded of
>> CODING_STYLE while others aren't.
>
> I still think we spend far too much time discussing this on list. =C2=A0W=
hile I
> stand corrected that we've ever had a bug because of this, I have a hard
> time believing this is anywhere in the top 10 list of issues that we have=
.

When an outsider submits a patch which gets reviewed, CODING_STYLE
issues can almost certainly be expected. The other frequent issues
(for example memory management) should be addressed by HACKING.