Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[Blue Swirl <blauwirbel@gmail.com>]

On Sun, Aug 22, 2010 at 7:44 PM, malc <av1474@comtv.ru> wrote:
> On Sun, 22 Aug 2010, Anthony Liguori wrote:
>
>> On 08/22/2010 01:56 PM, Blue Swirl wrote:
>> > > Why is this even still being discussed?  What problem are people actually
>> > > trying to solve?
>> > >
>> > > Can someone point to a bug in QEMU that's been caused because of
>> > > CODING_STYLE or the fact that some patches don't adhere to it?
>> > >
>> > 7b1df88f284f462ecb236931ad863a815f243195
>> >
>>
>> That's a hell of a bug :-)
>>
>> > > I don't see a problem with the way things are today.
>> > >
>> > There is the problem that some patch submitters are reminded of
>> > CODING_STYLE while others aren't.
>>
>> I still think we spend far too much time discussing this on list.  While I
>> stand corrected that we've ever had a bug because of this, I have a hard time
>> believing this is anywhere in the top 10 list of issues that we have.
>
> You don't.
>
> if (len != 4) {
>   /* TODO: Signal an error? */
> }
>
> Is just as affected and follows the style perfectly.

No. I think you missed a very, very important detail in the line with
the comment.

>>
>> Regards,
>>
>> Anthony Liguori
>>
>> >   Some don't need to be reminded but
>> > they are not part of the problem.
>> >
>
> You weirdly snipped that part, here it is in full:
>
>
>> There is the problem that some patch submitters are reminded of
>> CODING_STYLE while others aren't. Some don't need to be reminded but
>> they are not part of the problem.
>
> And to this i fully subscribe.
>
> --
> mailto:av1474@comtv.ru
>