From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39982 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnGfN-0005CH-0O for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnGYn-0005UA-SN for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:50:30 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:46819) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnGYn-0005U5-Nx for qemu-devel@nongnu.org; Sun, 22 Aug 2010 15:50:29 -0400 Received: by qyk31 with SMTP id 31so3933045qyk.4 for ; Sun, 22 Aug 2010 12:50:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C71550F.6080602@redhat.com> <4C716F43.8070805@codemonkey.ws> <4C717A6C.9080805@codemonkey.ws> From: Blue Swirl Date: Sun, 22 Aug 2010 19:50:09 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Jes Sorensen , Miguel Di Ciurcio Filho , Markus Armbruster , qemu-devel On Sun, Aug 22, 2010 at 7:44 PM, malc wrote: > On Sun, 22 Aug 2010, Anthony Liguori wrote: > >> On 08/22/2010 01:56 PM, Blue Swirl wrote: >> > > Why is this even still being discussed? =C2=A0What problem are peopl= e actually >> > > trying to solve? >> > > >> > > Can someone point to a bug in QEMU that's been caused because of >> > > CODING_STYLE or the fact that some patches don't adhere to it? >> > > >> > 7b1df88f284f462ecb236931ad863a815f243195 >> > >> >> That's a hell of a bug :-) >> >> > > I don't see a problem with the way things are today. >> > > >> > There is the problem that some patch submitters are reminded of >> > CODING_STYLE while others aren't. >> >> I still think we spend far too much time discussing this on list. =C2=A0= While I >> stand corrected that we've ever had a bug because of this, I have a hard= time >> believing this is anywhere in the top 10 list of issues that we have. > > You don't. > > if (len !=3D 4) { > =C2=A0 /* TODO: Signal an error? */ > } > > Is just as affected and follows the style perfectly. No. I think you missed a very, very important detail in the line with the comment. >> >> Regards, >> >> Anthony Liguori >> >> > =C2=A0 Some don't need to be reminded but >> > they are not part of the problem. >> > > > You weirdly snipped that part, here it is in full: > > >> There is the problem that some patch submitters are reminded of >> CODING_STYLE while others aren't. Some don't need to be reminded but >> they are not part of the problem. > > And to this i fully subscribe. > > -- > mailto:av1474@comtv.ru >