Re: [Qemu-devel] [PATCH V2] softfloat: Rename float*_is_nan() functions to float*_is_quiet_nan()

[Peter Maydell <peter.maydell@linaro.org>]

On 17 December 2010 15:56, Peter Maydell <peter.maydell@linaro.org> wrote:
> The softfloat functions float*_is_nan() were badly misnamed,
> because they return true only for quiet NaNs, not for all NaNs.
> Rename them to float*_is_quiet_nan() to more accurately reflect
> what they do.
>
> This change was produced by:
>  perl -p -i -e 's/_is_nan/_is_quiet_nan/g' $(git grep -l is_nan)
> (with the results manually checked.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>
> Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

Ping? This patch got no further comments (although it provoked
a long thread on a completely unrelated topic), it's been
reviewed and it still applies to master currently. I think it's
an uncontroversially good idea (~80% of current uses of the
functions are actually buggy because the people who wrote
them were misled by the function name!).

Can it be applied please? (cc'd Aurelien since you seem to be
committing various missed patches at the moment :-))

thanks
-- PMM