From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44423 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJnIl-0004Oc-Dg for qemu-devel@nongnu.org; Sat, 20 Nov 2010 08:16:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJnIk-0007AI-0o for qemu-devel@nongnu.org; Sat, 20 Nov 2010 08:16:23 -0500 Received: from mail-qw0-f45.google.com ([209.85.216.45]:61058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJnIj-00079x-UP for qemu-devel@nongnu.org; Sat, 20 Nov 2010 08:16:21 -0500 Received: by qwj8 with SMTP id 8so1672965qwj.4 for ; Sat, 20 Nov 2010 05:16:21 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1290241380.28657.102.camel@haakon2.linux-iscsi.org> References: <20101118144736.C183DF90AB@ochil.suse.de> <20101119183901.GI32461@lst.de> <1290213698.28657.62.camel@haakon2.linux-iscsi.org> <1290241380.28657.102.camel@haakon2.linux-iscsi.org> Date: Sat, 20 Nov 2010 13:16:20 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl From: adq Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Nicholas A. Bellinger" Cc: stefanha@gmail.com, kraxel@redhat.com, Christoph Hellwig , qemu-devel@nongnu.org, Hannes Reinecke On 20 November 2010 08:23, Nicholas A. Bellinger wrot= e: > On Sat, 2010-11-20 at 01:25 +0000, adq wrote: >> On 20 November 2010 00:41, Nicholas A. Bellinger w= rote: >> > On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >> >> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: >> >> > >> >> > aio_ioctl is emulated anyway and currently broken. >> >> >> >> What's broken about it currently? >> > >> > Mmmmmm, I do not recall this being broken in the first place..? =A0The= re >> > was a single issue with megasas+bdrv_aio_ioctl() with WinXP (that did >> > not appear with lsi53c895a) that was mentioned on the list earlier in >> > the year that required a patch to use bdev_ioctl(), but last I recall >> > Hannes had already fixed this in recent megasas.c code w/ 32-bit MSFT >> > guests. =A0Also, this is what I have been with scsi_generic.c and >> > scsi_bsg.c into TCM_loop in my v0.12.5 megasas tree, and I am not >> > observing any obvious issues with AIO IOCTLs for SG_IO/BSG into Linux >> > guests. >> > >> > I will give AIO IOCTL ops a run with these on v2.6.37-rc2 lock-less KV= M >> > host mode <-> TCM_Loop to verify against the v0.12.5 megasas tree. >> >> Could this AIO ioctl breakage perhaps be the one I fixed here? >> http://web.archiveorange.com/archive/v/1XS1vROmfC7dN9wYxsmt >> >> The patch is defintely in the latest git... it works fine for me with >> my scsi-generic MMC command patches. >> > > Interesting read, and thanks for the heads up on this bit.. =A0 I do not > personally recall running into any issues with TYPE_DISK w/ lsi53c895a > and AIO SG_IO into WinXP guests on v0.12.5 code. =A0 After a quick double > check in the v0.12.5 megasas tree, the proper get_async_context_id() is > still present: > > http://git.kernel.org/?p=3Dvirt/kvm/nab/qemu-kvm.git;a=3Dblob;f=3Dposix-a= io-compat.c;h=3Dccdbf9a16d0ef1d7e57c87dbe43f318d4c7a5967;hb=3DHEAD#l560 > > So it appears this acb->async_context_id was incorrectly dropped during > v0.13 development, and with your fix commited into v0.13 mainline code > that Hannes should be able to safetly drop this the megasas series, > yes..? > > Thank you for your comments! No problem. Oh, that bug was /definitely/ in the released 0.12.x series code; I spotted it when trying to get scsi-generic to work on arch linux, which was using 0.12.x.