From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32974 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OWZ7L-0002Ff-Lm
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 14:13:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OWZ7I-0003FJ-U8
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 14:13:07 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:54909)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OWZ7I-0003FA-PA
	for qemu-devel@nongnu.org; Wed, 07 Jul 2010 14:13:04 -0400
Received: by pwi2 with SMTP id 2so1898632pwi.4
	for <qemu-devel@nongnu.org>; Wed, 07 Jul 2010 11:12:56 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100707175534.GC14508@redhat.com>
References: <AANLkTim5y9JcKEduGP4A5rtGDaGW1dCngczppNXvItQz@mail.gmail.com>
	<20100707175534.GC14508@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Wed, 7 Jul 2010 18:12:36 +0000
Message-ID: <AANLkTik0446ijTDohJ7Nx5_JIiuWm9hFrU7lyBFSzKwh@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH, RFC] pci: handle BAR mapping at pci level
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, Jul 7, 2010 at 5:55 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Wed, Jul 07, 2010 at 05:53:08PM +0000, Blue Swirl wrote:
>> Add I/O port registration functions which separate registration
>> from the mapping stage.
>>
>> Move IOIO and MMIO BAR mapping to pci.c.
>>
>> TODO: fix dirty logging, coalesced MMIO and base address comparisons
>> (eepro100 etc). Bridge filtering may be broken. Broke virtio-pci and MSIX.
>
> legacy vga regions too?

Probably not, because VGA still works nicely at PC boot.

>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>
> Looks like a good direction to take.
>
>> ---
>> i386 boots but resets. PPC and Sparc64 can't even start.
>>
>> Patch also available at
>> git://repo.or.cz/qemu/blueswirl.git
>>
>> It may be worthwhile to break this into some kind of smaller steps.
>
> Definitely.
>

One way could be to leave map_func in place but if it's NULL, use
newer system. When all callers have converted cleanly, remove extra
NULL argument and map_func.

It would be nice to have some plan how to convert KVM stuff like dirty
logging and coalescing. Any ideas?