From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56063 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OewBv-0003Ky-OH for qemu-devel@nongnu.org; Fri, 30 Jul 2010 16:28:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OewBu-0000eA-NG for qemu-devel@nongnu.org; Fri, 30 Jul 2010 16:28:27 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:57277) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OewBu-0000e4-FN for qemu-devel@nongnu.org; Fri, 30 Jul 2010 16:28:26 -0400 Received: by wwc33 with SMTP id 33so181313wwc.10 for ; Fri, 30 Jul 2010 13:28:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1280345424-12918-1-git-send-email-miguel.filho@gmail.com> <1280345424-12918-3-git-send-email-miguel.filho@gmail.com> Date: Fri, 30 Jul 2010 17:28:25 -0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code From: Miguel Di Ciurcio Filho Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster wrote: > Why? > > I figure the next patch wants it, but if that's the reason, the commit > message should state it. > To better identify what happened and where, IMHO.