From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40915 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OODpi-0002aT-Fk
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 13:52:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OODph-0000Fi-GR
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 13:52:26 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:57388)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OODph-0000Fd-C9
	for qemu-devel@nongnu.org; Mon, 14 Jun 2010 13:52:25 -0400
Received: by pvg11 with SMTP id 11so1383865pvg.4
	for <qemu-devel@nongnu.org>; Mon, 14 Jun 2010 10:52:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m3r5kahs6j.fsf@blackfin.pond.sub.org>
References: <AANLkTil4CwbISuS_1rjpjF5zFgwGPkxU7WLrNv98q0kk@mail.gmail.com>
	<m3r5kahs6j.fsf@blackfin.pond.sub.org>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 14 Jun 2010 17:52:04 +0000
Message-ID: <AANLkTik0W6vM28U1A7IZL2rXb-2Zzog_AwaLwzHNfOtG@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 7/7] apic: qdev conversion cleanup
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, Jun 14, 2010 at 9:36 AM, Markus Armbruster <armbru@redhat.com> wrote:
> Blue Swirl <blauwirbel@gmail.com> writes:
>
>> Make APICState completely private to apic.c by using DeviceState
>> in external APIs.
>
> Could you explain why this is an improvement?

Outside of apic.c, there is no need to access APICState fields so we
can remove that privilege. We can move the device instantiation to the
board level where it belongs.