From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33323 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OuhK2-0007S5-V4
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 03:49:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OuhK1-000342-SB
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 03:49:58 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:37068)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OuhK1-00033v-Ms
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 03:49:57 -0400
Received: by qyk31 with SMTP id 31so4368344qyk.4
	for <qemu-devel@nongnu.org>; Sun, 12 Sep 2010 00:49:57 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <C8AD180F.10E18%wexu2@cisco.com>
References: <20d8ef39308fd49bf95d83485402fc20499674d3.1283931134.git.yamahata@valinux.co.jp>
	<C8AD180F.10E18%wexu2@cisco.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 12 Sep 2010 07:49:37 +0000
Message-ID: <AANLkTik2RGc0FtkJVyGSE9B8K6Hk6G7ETrsO2M2ALBkt@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie
	extended capability.
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wei Xu <wexu2@cisco.com>
Cc: skandasa@cisco.com, etmartin@cisco.com, mst@redhat.com, adhyas@gmail.com, qemu-devel@nongnu.org, Isaku Yamahata <yamahata@valinux.co.jp>

On Wed, Sep 8, 2010 at 5:38 PM, Wei Xu <wexu2@cisco.com> wrote:
> Isaku:
>
> For binary constants below, to achieve max compatibility with gcc versions,
> I recommend to change to hex (0x...):

Yes, binary constants were only added to GCC 4.3.x. Since they are
also GCC extensions with no obvious way to circumvent their use (as
with GCC attributes), they shouldn't be used.