From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60687 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oxl2I-0004RG-7F
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:24:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1Oxl2G-00008Z-EW
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:24:17 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:35035)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1Oxl2G-00008Q-3u
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 14:24:16 -0400
Received: by qwk4 with SMTP id 4so4020408qwk.4
	for <qemu-devel@nongnu.org>; Mon, 20 Sep 2010 11:24:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100920180840.GA31179@redhat.com>
References: <20100920180840.GA31179@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 20 Sep 2010 18:23:55 +0000
Message-ID: <AANLkTik33-2WDFXefGPpdtf7jho14VEjrjthFViUTZRc@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PULL] vhost,e1000 fixes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Sep 20, 2010 at 6:08 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> This fixes a bug in vhost error handling
> (also triggers build warning with vhost enabled)
> and fixes e1000 handling of short frames.
>
> Discussion on best ways to fix the e1000 issue
> is still ongoing but the =C2=A0bug is severe enough
> for some guests and the fix is safe enough
> that I feel we should have it fixed ASAP
> and look for that perfect approach later.
>
> Both fixes are 0.13 material IMO.
>
> The following changes since commit 952afb719f3c965bae12b5bd5f0f0f7ed0251c=
b8:
>
> =C2=A0mingw: use ASLR, no-SEH and DEP if available (2010-09-19 08:36:34 +=
0000)
>
> are available in the git repository at:
> =C2=A0git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anth=
ony
>
> Michael S. Tsirkin (1):
> =C2=A0 =C2=A0 =C2=A0vhost: fix infinite loop on error path

I don't think your fix is correct either, it will call the ioctl()
with file.index =3D=3D -1. How about int i; for (i =3D file.index; i >=3D 0=
;
i--) { file.index =3D i;... ?