From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55369 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PGTVE-0001Or-1z
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:31:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PGTVD-00008r-0i
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:31:31 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:34730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PGTVC-00008i-NZ
	for qemu-devel@nongnu.org; Thu, 11 Nov 2010 04:31:30 -0500
Received: by wyj26 with SMTP id 26so1812104wyj.4
	for <qemu-devel@nongnu.org>; Thu, 11 Nov 2010 01:31:29 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <8739r8vpt0.fsf@ginnungagap.bsc.es>
References: <20101109140818.29831.83592.stgit@ginnungagap.bsc.es>
	<20101109140848.29831.72280.stgit@ginnungagap.bsc.es>
	<AANLkTimJB+NEHui9BghWJf3sESz724hqj-O_Lfj4oreW@mail.gmail.com>
	<87tyjpvz3m.fsf@ginnungagap.bsc.es>
	<AANLkTim6Xu4TWK94jQ=_Oud1-PpZSPsp3YTqnM6vmGoS@mail.gmail.com>
	<87eiatuf2p.fsf@ginnungagap.bsc.es>
	<AANLkTi=3WiDOftp8ECd2UA57FigHoxEkr-981zvE2WTP@mail.gmail.com>
	<8739r8vpt0.fsf@ginnungagap.bsc.es>
Date: Thu, 11 Nov 2010 09:31:28 +0000
Message-ID: <AANLkTik5eNSqcS0EAi2dZh5bPw2EpGWkH=8OO7fAoHyZ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] trace: enable all events by default
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Nov 10, 2010 at 9:20 PM, Llu=EDs <xscript@gmx.net> wrote:
> Blue Swirl writes:
>
>> On Wed, Nov 10, 2010 at 7:57 PM, Llu=EDs <xscript@gmx.net> wrote:
>>> Blue Swirl writes:
>>>
>>>> On Wed, Nov 10, 2010 at 5:59 PM, Llu=EDs <xscript@gmx.net> wrote:
>>>>> So, my patch is just a matter of having all events available _only_ w=
hen
>>>>> you use a backend other than "nop".
>>>
>>>> Then the default for simpletrace (and dtrace?) should also be disabled
>>>> initial state. If you have 1000 tracepoints automatically enabled at
>>>> start (with simpletrace, not nop), disabling all of them if you are
>>>> only interested in a few of them is difficult.
>>>
>>> That's how it is. The patch sets always ".state=3D0" in "simple", and
>>> "dtrace" just does not do anything unless you plug something into the
>>> probe (similarly with "ust").
>
>> Oh, I missed .state=3D0 part, it was also not mentioned in the
>> description. Then these changes should be OK.
>
> My fault. If these are to be merged I can cook up a new series with a
> more verbose description.

Jan Kiszka suggested a solution for the simple trace backend: have a
qemu -trace events=3D<file> command-line option that enables the trace
events listed in the file on startup.  Then we can really get rid of
disable.  On LTTng UST and SystemTap building with everything in is a
good default, the user must explicitly enable probes at runtime with
those trace backends anyway.

Currently .state =3D 0 makes the simple backend less usable since it's a
drag to manually enable trace events from the monitor every time.

Stefan