From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59976 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcxRj-0000IZ-7W
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 04:56:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PcxRi-00080C-63
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 04:56:51 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:35117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PcxRh-0007zs-TQ
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 04:56:50 -0500
Received: by wyg36 with SMTP id 36so404002wyg.4
	for <qemu-devel@nongnu.org>; Wed, 12 Jan 2011 01:56:49 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.00.1101120911001.15581@sg-desktop.belvok.com>
References: <alpine.DEB.2.00.1101102325100.3913@sg-laptop>
	<alpine.DEB.2.00.1101120911001.15581@sg-desktop.belvok.com>
Date: Wed, 12 Jan 2011 09:56:48 +0000
Message-ID: <AANLkTik7nttePVUC5j-jL-xGBTD53SMJDOKmAdmJUNrO@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH] slirp/tftp.c: fix mode field
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sergei Gavrikov <sergei.gavrikov@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Wed, Jan 12, 2011 at 7:22 AM, Sergei Gavrikov
<sergei.gavrikov@gmail.com> wrote:
> diff --git a/slirp/tftp.c b/slirp/tftp.c
> index 55e4692..a455ad1 100644
> --- a/slirp/tftp.c
> +++ b/slirp/tftp.c
> @@ -311,7 +311,7 @@ static void tftp_handle_rrq(Slirp *slirp, struct tftp=
_t *tp, int pktlen)
> =A0 =A0 return;
> =A0 }
>
> - =A0if (memcmp(&tp->x.tp_buf[k], "octet\0", 6) !=3D 0) {
> + =A0if (strcasecmp((const char *)&tp->x.tp_buf[k], "octet") !=3D 0) {
> =A0 =A0 =A0 tftp_send_error(spt, 4, "Unsupported transfer mode", tp);
> =A0 =A0 =A0 return;
> =A0 }

According to RFC 2349 the "tsize" option is also case-insensitive.
Want to include a fix for that in this patch?

Stefan