From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59793 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OKcR1-00087L-AM for qemu-devel@nongnu.org; Fri, 04 Jun 2010 15:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OKcQz-00039d-FZ for qemu-devel@nongnu.org; Fri, 04 Jun 2010 15:20:02 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:56284) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OKcQz-00039K-BE for qemu-devel@nongnu.org; Fri, 04 Jun 2010 15:20:01 -0400 Received: by pvg12 with SMTP id 12so751496pvg.4 for ; Fri, 04 Jun 2010 12:20:00 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1275524816-4187-2-git-send-email-rth@twiddle.net> References: <1275524816-4187-1-git-send-email-rth@twiddle.net> <1275524816-4187-2-git-send-email-rth@twiddle.net> From: Blue Swirl Date: Fri, 4 Jun 2010 19:19:40 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/2] tcg: Add TYPE parameter to tcg_out_mov. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On Thu, Jun 3, 2010 at 12:26 AM, Richard Henderson wrote: > Mirror tcg_out_movi in having a TYPE parameter. =C2=A0This allows x86_64 > to perform the move at the proper width, which may elide a REX prefix. > > Introduce a TCG_TYPE_REG enumerator to represent the "native width" > of the host register, and to distinguish the usage from "pointer data" > as represented by the existing TCG_TYPE_PTR. > > Update all targets to match. > > Signed-off-by: Richard Henderson Sparc part looks fine to me. > + > + =C2=A0 =C2=A0/* An alias for the size of the native pointer. =C2=A0We d= on't currently > + =C2=A0 =C2=A0 =C2=A0 support any hosts with 64-bit registers and 32-bit= pointers. =C2=A0*/ Sparc32plus would match, though the ABI does not guarantee that higher 32 bits are preserved.