From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46520 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKeO0-0001kL-GC
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 16:57:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PKeNr-0008IB-Hu
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 16:57:20 -0500
Received: from mail-ey0-f173.google.com ([209.85.215.173]:55826)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PKeNr-0008I5-Db
	for qemu-devel@nongnu.org; Mon, 22 Nov 2010 16:57:11 -0500
Received: by eya25 with SMTP id 25so4629198eya.4
	for <qemu-devel@nongnu.org>; Mon, 22 Nov 2010 13:57:10 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20101122101536.649BAF8D70@ochil.suse.de>
References: <20101122101536.649BAF8D70@ochil.suse.de>
Date: Mon, 22 Nov 2010 21:56:47 +0000
Message-ID: <AANLkTik=HzOykPQqwomfMax2kOLZt2KMFjynTEFw-j14@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] scsi: Implement 'get_sense' callback
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: qemu-devel@nongnu.org, nab@linux-iscsi.org, kraxel@redhat.com

On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke <hare@suse.de> wrote:
> +static int scsi_get_sense(SCSIRequest *req, uint8_t *outbuf, int len)
> +{
> + =A0 =A0SCSIGenericState *s =3D DO_UPCAST(SCSIGenericState, qdev, req->d=
ev);
> + =A0 =A0int size =3D SCSI_SENSE_BUF_SIZE;

If there is no error we return SCSI_SENSE_BUF_SIZE without touching
outbuf?  I was expecting a memset(outbuf, 0, ...) or something that
initializes outbuf.

> +
> + =A0 =A0if (s->driver_status & SG_ERR_DRIVER_SENSE) {
> + =A0 =A0 =A0 =A0if (len < SCSI_SENSE_BUF_SIZE)

{}

> + =A0 =A0 =A0 =A0 =A0 =A0size =3D len;
> + =A0 =A0 =A0 =A0else

{}

Stefan