From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43911 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q0rgL-0007DZ-9j
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 04:38:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q0rgJ-0006mg-Te
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 04:38:44 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:58375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1Q0rgJ-0006mc-Oh
	for qemu-devel@nongnu.org; Sat, 19 Mar 2011 04:38:43 -0400
Received: by vxb41 with SMTP id 41so4515373vxb.4
	for <qemu-devel@nongnu.org>; Sat, 19 Mar 2011 01:38:43 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4D833890.8040403@web.de>
References: <4D73A3BD.2000405@web.de> <4D833890.8040403@web.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 19 Mar 2011 10:38:23 +0200
Message-ID: <AANLkTikC93+d+SitsXZ2aa5FSAEMS2uBtgFu5MJDPqMn@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] i8254: Fix migration from older versions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

Thanks, applied.

On Fri, Mar 18, 2011 at 12:48 PM, Jan Kiszka <jan.kiszka@web.de> wrote:
> On 2011-03-06 16:09, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> qdev conversion broke migration as the previous version used vmstate
>> instance IDs derived from the iobase. Fix it by registering a legacy
>> alias.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> =C2=A0hw/i8254.c | =C2=A0 =C2=A02 ++
>> =C2=A01 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/i8254.c b/hw/i8254.c
>> index eaf5d3e..47c9d73 100644
>> --- a/hw/i8254.c
>> +++ b/hw/i8254.c
>> @@ -520,6 +520,8 @@ static int pit_initfn(ISADevice *dev)
>> =C2=A0 =C2=A0 =C2=A0register_ioport_read(pit->iobase, 3, 1, pit_ioport_r=
ead, pit);
>> =C2=A0 =C2=A0 =C2=A0isa_init_ioport(dev, pit->iobase);
>>
>> + =C2=A0 =C2=A0qdev_set_legacy_instance_id(&dev->qdev, pit->iobase, 2);
>> +
>> =C2=A0 =C2=A0 =C2=A0return 0;
>> =C2=A0}
>>
>
> This bug is still open.
>
> Jan
>
>