From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46922 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OpHL6-00083l-Dx
	for qemu-devel@nongnu.org; Sat, 28 Aug 2010 05:04:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OpHKy-0004zv-7C
	for qemu-devel@nongnu.org; Sat, 28 Aug 2010 05:04:40 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:35176)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OpHKy-0004zo-3l
	for qemu-devel@nongnu.org; Sat, 28 Aug 2010 05:04:32 -0400
Received: by qyk5 with SMTP id 5so1500614qyk.4
	for <qemu-devel@nongnu.org>; Sat, 28 Aug 2010 02:04:31 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20100824050631.GK20428@valinux.co.jp>
References: <1bdc30e5adedf2534f7619a40bddfc2a2a8b138f.1280911374.git.yamahata@valinux.co.jp>
	<20100824050631.GK20428@valinux.co.jp>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 28 Aug 2010 09:04:11 +0000
Message-ID: <AANLkTikFH5SS8ewxZoQNxEMaF0vbXzW=fa2bvcmK9JRx@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] isapc: fix segfault.
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Thanks, applied.

On Tue, Aug 24, 2010 at 5:06 AM, Isaku Yamahata <yamahata@valinux.co.jp> wr=
ote:
> Ping.
>
> On Wed, Aug 04, 2010 at 05:43:20PM +0900, Isaku Yamahata wrote:
>> https://bugs.launchpad.net/bugs/611646
>> reports that ./i386-softmmu/qemu -M isapc segfaults.
>> This patch fixes the segfault introduced by
>> f885f1eaa8711c06033ceb1599e3750fb37c306f
>>
>> It's because i440fx_state in pc_init1() isn't initialized.
>>
>> > Core was generated by `./i386-softmmu/qemu -M isapc'.
>> > Program terminated with signal 11, Segmentation fault.
>> > [New process 19686]
>> > =C2=A0 =C2=A0 at qemu/hw/piix_pci.c:136
>> > (gdb) where
>> > =C2=A0 =C2=A0 at qemu/hw/piix_pci.c:136
>> > =C2=A0 =C2=A0 boot_device=3D0x7fffe1f5b040 "cad", kernel_filename=3D0x=
0,
>> > =C2=A0 =C2=A0 kernel_cmdline=3D0x6469bf "", initrd_filename=3D0x0,
>> > =C2=A0 =C2=A0 cpu_model=3D0x654d10 "486", pci_enabled=3D0)
>> > =C2=A0 =C2=A0 at qemu/hw/pc_piix.c:178
>> > =C2=A0 =C2=A0 boot_device=3D0x7fffe1f5b040 "cad", kernel_filename=3D0x=
0,
>> > =C2=A0 =C2=A0 kernel_cmdline=3D0x6469bf "", initrd_filename=3D0x0, cpu=
_model=3D0x654d10 "486")
>> > =C2=A0 =C2=A0 at qemu/hw/pc_piix.c:207
>> > =C2=A0 =C2=A0 envp=3D0x7fffe1f5b188)
>> > =C2=A0 =C2=A0 at qemu/vl.c:2871
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>> ---
>> =C2=A0hw/pc_piix.c | =C2=A0 =C2=A01 +
>> =C2=A01 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index 812ddfd..34c65d5 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size,
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pci_bus =3D i440fx_init(&i440fx_state,=
 &piix3_devfn, isa_irq, ram_size);
>> =C2=A0 =C2=A0 =C2=A0} else {
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pci_bus =3D NULL;
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0i440fx_state =3D NULL;
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0isa_bus_new(NULL);
>> =C2=A0 =C2=A0 =C2=A0}
>> =C2=A0 =C2=A0 =C2=A0isa_bus_irqs(isa_irq);
>> --
>> 1.7.1.1
>>
>>
>
> --
> yamahata
>
>