* [Qemu-devel] [PATCH] isapc: fix segfault.
@ 2010-08-04 8:43 Isaku Yamahata
2010-08-24 5:06 ` Isaku Yamahata
0 siblings, 1 reply; 3+ messages in thread
From: Isaku Yamahata @ 2010-08-04 8:43 UTC (permalink / raw)
To: qemu-devel; +Cc: yamahata, Markus Armbruster
https://bugs.launchpad.net/bugs/611646
reports that ./i386-softmmu/qemu -M isapc segfaults.
This patch fixes the segfault introduced by
f885f1eaa8711c06033ceb1599e3750fb37c306f
It's because i440fx_state in pc_init1() isn't initialized.
> Core was generated by `./i386-softmmu/qemu -M isapc'.
> Program terminated with signal 11, Segmentation fault.
> [New process 19686]
> at qemu/hw/piix_pci.c:136
> (gdb) where
> at qemu/hw/piix_pci.c:136
> boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> kernel_cmdline=0x6469bf "", initrd_filename=0x0,
> cpu_model=0x654d10 "486", pci_enabled=0)
> at qemu/hw/pc_piix.c:178
> boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> kernel_cmdline=0x6469bf "", initrd_filename=0x0, cpu_model=0x654d10 "486")
> at qemu/hw/pc_piix.c:207
> envp=0x7fffe1f5b188)
> at qemu/vl.c:2871
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pc_piix.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 812ddfd..34c65d5 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size,
pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, isa_irq, ram_size);
} else {
pci_bus = NULL;
+ i440fx_state = NULL;
isa_bus_new(NULL);
}
isa_bus_irqs(isa_irq);
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] isapc: fix segfault.
2010-08-04 8:43 [Qemu-devel] [PATCH] isapc: fix segfault Isaku Yamahata
@ 2010-08-24 5:06 ` Isaku Yamahata
2010-08-28 9:04 ` Blue Swirl
0 siblings, 1 reply; 3+ messages in thread
From: Isaku Yamahata @ 2010-08-24 5:06 UTC (permalink / raw)
To: qemu-devel; +Cc: Markus Armbruster
Ping.
On Wed, Aug 04, 2010 at 05:43:20PM +0900, Isaku Yamahata wrote:
> https://bugs.launchpad.net/bugs/611646
> reports that ./i386-softmmu/qemu -M isapc segfaults.
> This patch fixes the segfault introduced by
> f885f1eaa8711c06033ceb1599e3750fb37c306f
>
> It's because i440fx_state in pc_init1() isn't initialized.
>
> > Core was generated by `./i386-softmmu/qemu -M isapc'.
> > Program terminated with signal 11, Segmentation fault.
> > [New process 19686]
> > at qemu/hw/piix_pci.c:136
> > (gdb) where
> > at qemu/hw/piix_pci.c:136
> > boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> > kernel_cmdline=0x6469bf "", initrd_filename=0x0,
> > cpu_model=0x654d10 "486", pci_enabled=0)
> > at qemu/hw/pc_piix.c:178
> > boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
> > kernel_cmdline=0x6469bf "", initrd_filename=0x0, cpu_model=0x654d10 "486")
> > at qemu/hw/pc_piix.c:207
> > envp=0x7fffe1f5b188)
> > at qemu/vl.c:2871
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> hw/pc_piix.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 812ddfd..34c65d5 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size,
> pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, isa_irq, ram_size);
> } else {
> pci_bus = NULL;
> + i440fx_state = NULL;
> isa_bus_new(NULL);
> }
> isa_bus_irqs(isa_irq);
> --
> 1.7.1.1
>
>
--
yamahata
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] isapc: fix segfault.
2010-08-24 5:06 ` Isaku Yamahata
@ 2010-08-28 9:04 ` Blue Swirl
0 siblings, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2010-08-28 9:04 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: qemu-devel, Markus Armbruster
Thanks, applied.
On Tue, Aug 24, 2010 at 5:06 AM, Isaku Yamahata <yamahata@valinux.co.jp> wrote:
> Ping.
>
> On Wed, Aug 04, 2010 at 05:43:20PM +0900, Isaku Yamahata wrote:
>> https://bugs.launchpad.net/bugs/611646
>> reports that ./i386-softmmu/qemu -M isapc segfaults.
>> This patch fixes the segfault introduced by
>> f885f1eaa8711c06033ceb1599e3750fb37c306f
>>
>> It's because i440fx_state in pc_init1() isn't initialized.
>>
>> > Core was generated by `./i386-softmmu/qemu -M isapc'.
>> > Program terminated with signal 11, Segmentation fault.
>> > [New process 19686]
>> > at qemu/hw/piix_pci.c:136
>> > (gdb) where
>> > at qemu/hw/piix_pci.c:136
>> > boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
>> > kernel_cmdline=0x6469bf "", initrd_filename=0x0,
>> > cpu_model=0x654d10 "486", pci_enabled=0)
>> > at qemu/hw/pc_piix.c:178
>> > boot_device=0x7fffe1f5b040 "cad", kernel_filename=0x0,
>> > kernel_cmdline=0x6469bf "", initrd_filename=0x0, cpu_model=0x654d10 "486")
>> > at qemu/hw/pc_piix.c:207
>> > envp=0x7fffe1f5b188)
>> > at qemu/vl.c:2871
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>> ---
>> hw/pc_piix.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index 812ddfd..34c65d5 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -103,6 +103,7 @@ static void pc_init1(ram_addr_t ram_size,
>> pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, isa_irq, ram_size);
>> } else {
>> pci_bus = NULL;
>> + i440fx_state = NULL;
>> isa_bus_new(NULL);
>> }
>> isa_bus_irqs(isa_irq);
>> --
>> 1.7.1.1
>>
>>
>
> --
> yamahata
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-28 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-04 8:43 [Qemu-devel] [PATCH] isapc: fix segfault Isaku Yamahata
2010-08-24 5:06 ` Isaku Yamahata
2010-08-28 9:04 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).