From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47439 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxGPz-0005qX-5J
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:15:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <corentin.chary@gmail.com>) id 1PxGPw-0004x0-QF
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:14:58 -0500
Received: from mail-ew0-f45.google.com ([209.85.215.45]:48515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <corentin.chary@gmail.com>) id 1PxGPw-0004wn-Ji
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:14:56 -0500
Received: by ewy24 with SMTP id 24so114198ewy.4
	for <qemu-devel@nongnu.org>; Wed, 09 Mar 2011 02:14:55 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4D7752A5.6080405@web.de>
References: <2640D58E-2101-47FA-99B6-28815666651E@dlh.net>
	<4D772E4C.6020604@web.de>
	<AANLkTikAOH2nR3T7iqrKj226MrH+8O9DXC=J+7XK-Av_@mail.gmail.com>
	<4D774282.9060102@web.de>
	<AANLkTim9rECCG+kA6=5BE1sZ_b7fN=vRGM+M8hbMiNy8@mail.gmail.com>
	<4D774F54.2050004@web.de> <4D77503D.6070605@web.de>
	<AANLkTiny_WfkKCBZoRu5OqU5mzW3fKCSQJydHKDTVuCE@mail.gmail.com>
	<4D7752A5.6080405@web.de>
Date: Wed, 9 Mar 2011 10:14:55 +0000
Message-ID: <AANLkTikFbefhdxGBAzdB4BA2QgoMK5Z-Dd07qctuPN-d@mail.gmail.com>
Subject: Re: [Qemu-devel] Re: segmentation fault in qemu-kvm-0.14.0
From: Corentin Chary <corentin.chary@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Lieven <pl@dlh.net>, qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org, Anthony Liguori <aliguori@linux.vnet.ibm.com>

>> Cheap stuff is done by the main thread (cursor, etc...). The thread
>> only do framebuffer updates.
>
> And both are synchronized with a vnc-private lock only?

Yes

> The problem with this model is the non-threaded qemu execution model.
> Even if we acquire the global mutex to protect handler updates against
> the main select loop, this won't help here. So vnc-threading likely
> needs to be made dependent on --enable-io-thread.

Plus proper lock_iothread() calls right ?

If yes I'll send a patch for that (or you can do it, as you want).

Thanks,

-- 
Corentin Chary
http://xf.iksaif.net