From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36383 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYmDj-0007de-Cf for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PYmDi-0005lh-3V for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:09:07 -0500 Received: from mail-vw0-f45.google.com ([209.85.212.45]:43993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PYmDh-0005lc-Rm for qemu-devel@nongnu.org; Fri, 31 Dec 2010 16:09:06 -0500 Received: by vws12 with SMTP id 12so4678496vws.4 for ; Fri, 31 Dec 2010 13:09:05 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1293828880-25429-1-git-send-email-aurelien@aurel32.net> References: <1293828880-25429-1-git-send-email-aurelien@aurel32.net> Date: Fri, 31 Dec 2010 21:09:04 +0000 Message-ID: From: Peter Maydell Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 31 December 2010 20:54, Aurelien Jarno wrote: > UMAAL should use unsigned multiply instead of signed. > > This patch fixes this issue by handling UMAAL separately from > UMULL/UMLAL/SMULL/SMLAL as these instructions are different > enough. It also explicitly list instructions in case and catch > nonexistent instruction as illegal. Also fixes a few style issues. > > This fixes the issues reported in > https://bugs.launchpad.net/qemu/+bug/696015 > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno Thanks for the tweaks, looks good to me. Reviewed-by: Peter Maydell -- PMM